Fix transpiler to allow : in dynamic variables. (#680) (#717)

Fix transpiler regex to allow ':' characters in dynamic variables so
that users can input "${dynamic.lookup|'fallback.here'}".

Co-authored-by: Aleksandr Maus <aleksandr.maus@elastic.co>
(cherry picked from commit 0560b46)

Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com>

CHANGELOG.next.asciidoc

@@ -104,6 +104,7 @@
 - Collects stdout and stderr of applications run as a process and logs them. {issue}[88]
 - Remove VerificationMode option to empty string. Default value is `full`. {issue}[184]
 - diagnostics collect file mod times are set. {pull}570[570]
+- Allow ':' characters in dynamic variables {issue}624[624] {pull}680[680]
 - Allow the - char to appear as part of variable names in eql expressions. {issue}709[709] {pull}710[710]
 
 ==== New features

internal/pkg/agent/transpiler/vars.go

@@ -14,7 +14,7 @@ import (
 	"github.com/elastic/elastic-agent/internal/pkg/core/composable"
 )
 
-var varsRegex = regexp.MustCompile(`\${([\p{L}\d\s\\\-_|.'"]*)}`)
+var varsRegex = regexp.MustCompile(`\${([\p{L}\d\s\\\-_|.'":]*)}`)
 
 // ErrNoMatch is return when the replace didn't fail, just that no vars match to perform the replace.
 var ErrNoMatch = fmt.Errorf("no matching vars")

internal/pkg/agent/transpiler/vars_test.go

@@ -81,12 +81,24 @@ func TestVars_Replace(t *testing.T) {
 			false,
 			false,
 		},
+		{
+			`${"with:colon"}`,
+			NewStrVal("with:colon"),
+			false,
+			false,
+		},
 		{
 			`${"direct"}`,
 			NewStrVal("direct"),
 			false,
 			false,
 		},
+		{
+			`${un-der_score.missing|'with:colon'}`,
+			NewStrVal("with:colon"),
+			false,
+			false,
+		},
 		{
 			`${un-der_score.}`,
 			NewStrVal(""),