Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.3](backport #680) Fix transpiler to allow : in dynamic variables. #717

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 13, 2022

This is an automatic backport of pull request #680 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Fix transpiler regex to allow ':' characters in dynamic variables so
that users can input "${dynamic.lookup|'fallback.here'}".

Co-authored-by: Aleksandr Maus <aleksandr.maus@elastic.co>
(cherry picked from commit 0560b46)
@mergify mergify bot requested a review from a team as a code owner July 13, 2022 19:41
@mergify mergify bot added the backport label Jul 13, 2022
@mergify mergify bot requested review from aleksmaus and michel-laterman and removed request for a team July 13, 2022 19:41
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-13T19:41:47.962+0000

  • Duration: 23 min 46 sec

Test stats 🧪

Test Results
Failed 0
Passed 6011
Skipped 23
Total 6034

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 97.222% (70/72) 👍
Files 68.636% (151/220) 👍
Classes 68.254% (301/441) 👍
Methods 51.722% (826/1597) 👍
Lines 37.997% (8851/23294) 👎 -0.017
Conditionals 100.0% (0/0) 💚

@michel-laterman michel-laterman merged commit 197ce33 into 8.3 Jul 13, 2022
@michel-laterman michel-laterman deleted the mergify/bp/8.3/pr-680 branch July 13, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants