Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heatmap labels are hard to see with dark theme #2347

Closed
drewdaemon opened this issue Mar 1, 2024 · 5 comments
Closed

Heatmap labels are hard to see with dark theme #2347

drewdaemon opened this issue Mar 1, 2024 · 5 comments
Assignees
Labels
bug Something isn't working :heatmap Heatmap/Swimlane chart related issue :theme

Comments

@drewdaemon
Copy link
Contributor

Describe the issue
When EUI_CHARTS_THEME_DARK is used as the theme for a heatmap (per these directions), the labels are very dark.

To Reproduce
Sandbox

Expected behaviour
The labels should be light enough to contrast with the background.

Screenshots
Screenshot 2024-03-01 at 5 37 09 AM

Version (please complete the following information):

  • OS: OSX
  • Browser: Brave, Edge, etc
  • Elastic Charts: 64.0.0
@drewdaemon drewdaemon added bug Something isn't working :heatmap Heatmap/Swimlane chart related issue :theme labels Mar 1, 2024
@nickofthyme
Copy link
Collaborator

Thanks @drewdaemon, that usage is no longer the ideal approach as we are deprecating the theme consumed from eui in favor of our new charts LIGHT_THEME and DARK_THEME from #2175. My next task is to update the eui docs and exports to reflect this change.

@nickofthyme nickofthyme self-assigned this Mar 7, 2024
@drewdaemon
Copy link
Contributor Author

@jpcarey see the above guidance to resolve your issue with the dark theme on the heatmap vis. Try importing LIGHT_THEME and DARK_THEME from the charts library instead of using the EUI themes.

@nickofthyme
Copy link
Collaborator

Also see elastic/kibana#170914 (comment) for changes applied to kibana.

@nickofthyme
Copy link
Collaborator

Closing as we are updating the eui docs to reflect this change in elastic/eui#7572

image

@jpcarey
Copy link

jpcarey commented Mar 13, 2024

That worked, thank you @nickofthyme and @drewdaemon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working :heatmap Heatmap/Swimlane chart related issue :theme
Projects
None yet
Development

No branches or pull requests

3 participants