Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(charts): remove eui chart theme #7572

Merged
merged 11 commits into from
Mar 15, 2024
Merged

chore(charts): remove eui chart theme #7572

merged 11 commits into from
Mar 15, 2024

Conversation

nickofthyme
Copy link
Contributor

@nickofthyme nickofthyme commented Mar 12, 2024 •
edited
Loading

Summary

This PR is the final step in removing the @elastic/charts theme from eui, see elastic/elastic-charts#2069.

In elastic/elastic-charts#2175 we merged the legacy chart theme in the exact way the EUI_CHARTS_THEME_<DARK|LIGHT>.theme was created and exported as THEME_<DARK|LIGHT> from @elastic/charts.

Following the removal of all references to EUI_CHARTS_THEME_<DARK|LIGHT> in elastic/kibana#170914 we are now deprecating these exports from eui to be removed in a future breaking change.

General checklist

  • Browser QA
    • Checked in both light and dark modes
  • Docs site QA
  • Release checklist
    • A changelog entry exists and is marked appropriately.

@nickofthyme nickofthyme marked this pull request as ready for review March 12, 2024 19:55
@nickofthyme nickofthyme requested a review from a team as a code owner March 12, 2024 19:55
@nickofthyme nickofthyme mentioned this pull request Mar 12, 2024
Closed
@nickofthyme nickofthyme enabled auto-merge (squash) March 13, 2024 00:49
@nickofthyme nickofthyme requested a review from cee-chen March 14, 2024 01:45
@nickofthyme nickofthyme mentioned this pull request Mar 14, 2024
Closed
1 task
@cee-chen
Copy link
Contributor

Changes look fantastic. My only remaining comment is that I'd love to go ahead and get rid of the remaining EUI_SPARKLINE_THEME_PARTIAL import in this PR, but if you don't have time for it right now I'm also okay punting on it for later - just let me know your preference!

@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cee-chen
cee-chen approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@nickofthyme nickofthyme merged commit 53c140e into elastic:main Mar 15, 2024
7 checks passed
@nickofthyme nickofthyme deleted the rm-eui-chart-theme branch March 15, 2024 00:58
@cee-chen cee-chen mentioned this pull request Mar 18, 2024
Merged
@nickofthyme nickofthyme mentioned this pull request Mar 18, 2024
Closed
5 tasks
@cee-chen cee-chen mentioned this pull request Mar 21, 2024
Open
35 tasks
cee-chen added a commit to elastic/kibana that referenced this pull request Mar 22, 2024
@cee-chen
Upgrade EUI to v93.4.0 (#178890)
3a16585 
`v93.3.0`⏩ `v93.4.0`

---

## [`v93.4.0`](https://github.com/elastic/eui/releases/v93.4.0)

- Added the following properties to `EuiButtonGroup`'s `options`
configs: `toolTipContent`, `toolTipProps`, and `title`. These new
properties allow wrapping buttons in `EuiToolTips`, and additionally
customizing or disabling the native browser `title` tooltip.
([#7461](elastic/eui#7461))
- Enhanced `EuiResizeObserver` and `useResizeObserver`'s performance to
not trigger page reflows on resize event
([#7575](elastic/eui#7575))
- Updated `EuiSuperUpdateButton` to support custom button text via an
optional `children` prop
([#7576](elastic/eui#7576))

**Bug fixes**

- Fixed `EuiFlyout` to not repeatedly remove/add a body class on resize
([#7462](elastic/eui#7462))
- Fixed `EuiToast` title text to wrap instead of overflowing out of the
container ([#7568](elastic/eui#7568))
- Fixed a visual bug with `EuiHeaderBreadcrumbs` with popovers
([#7580](elastic/eui#7580))

**Deprecations**

- Deprecated `euiPalettePositive` and `euiPaletteNegative` in favour of
a more culturally inclusive `euiPaletteGreen` and `euiPaletteRed`
([#7570](elastic/eui#7570))
- Deprecated all charts theme exports in favor of `@elastic/charts`
exports: ([#7572](elastic/eui#7572))
- Deprecated `EUI_CHARTS_THEME_<DARK|LIGHT>` in favor of
`<DARK|LIGHT>_THEME` from `@elastic/charts`.
([#7572](elastic/eui#7572))
- Deprecated `EUI_SPARKLINE_THEME_PARTIAL` in favor of
`useSparklineOverrides` theme from the kibana `charts` plugin `theme`
service.

**Accessibility**

- Updated `EuiModal` to set an `aria-modal` attribute and a default
`dialog` role ([#7564](elastic/eui#7564))
- Updated `EuiConfirmModal` to set a default `alertdialog` role
([#7564](elastic/eui#7564))
- Fixed `EuiModal` and `EuiConfirmModal` to properly trap
Safari+VoiceOver's virtual cursor
([#7564](elastic/eui#7564))
@nickofthyme nickofthyme mentioned this pull request Apr 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cee-chen cee-chen cee-chen approved these changes

Assignees
No one assigned
Labels
Elastic Charts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nickofthyme @cee-chen @kibanamachine @elasticmachine