chore: reclaim charts theme ownership from eui #2175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickofthyme
added
:styling
nickofthyme
commented
Sep 20, 2023
nickofthyme
commented
Sep 21, 2023
nickofthyme
changed the title
|
buildkite update screenshots |
markov00
reviewed
Sep 25, 2023
|
buildkite update screenshots |
3 tasks
nickofthyme
force-pushed
the
charts-owned-theme
branch
from
f334666 to
95d1297
Compare
nickofthyme
force-pushed
the
charts-owned-theme
branch
from
39c63ff to
81f7a24
Compare
nickofthyme
commented
Oct 14, 2023
nickofthyme
force-pushed
the
charts-owned-theme
branch
from
f7ff12f to
139a4ad
Compare
nickofthyme
force-pushed
the
charts-owned-theme
branch
from
62b6ad9 to
269b7ac
Compare
|
buildkite update screenshots |
|
buildkite update screenshots |
|
buildkite test this |
nickofthyme
pushed a commit
that referenced
this pull request
Nov 8, 2023
# [61.0.0](v60.0.0...v61.0.0) (2023-11-08) ### Bug Fixes * `onRenderChange` callback trigger on resize ([#2228](#2228)) ([be30c1b](be30c1b)) * **axis:** always render `tickLine` unless `visible` is `false` ([#2194](#2194)) ([ec95d50](ec95d50)) * **BarSeries:** ignore histogram mode in determining stacked series ([#2225](#2225)) ([27b4281](27b4281)) * clamp brushing min of last bucket ([#2227](#2227)) ([155c22d](155c22d)) * **deps:** update dependency @elastic/eui to ^88.5.0 ([#2179](#2179)) ([2bb921e](2bb921e)) * **deps:** update dependency @elastic/eui to ^88.5.4 ([#2190](#2190)) ([05b33e5](05b33e5)) * **deps:** update dependency @elastic/eui to ^89.1.0 ([#2212](#2212)) ([a91f68d](a91f68d)) * **deps:** update dependency @elastic/eui to v89 ([#2193](#2193)) ([132327d](132327d)) * **deps:** update dependency @elastic/eui to v90 ([#2222](#2222)) ([10cd53b](10cd53b)) ### chore * reclaim charts theme ownership from eui ([#2175](#2175)) ([422c7d5](422c7d5)) ### Features * **metric:** allow alpha colors and improve contrast logic ([#2184](#2184)) ([dd5732e](dd5732e)) ### BREAKING CHANGES * **BarSeries:** now ignores histogram mode in determining stacked series * elastic charts theme renamed to `LEGACY_DARK_THEME` and `LEGACY_LIGHT_THEME` in favor of the main `DARK_THEME` and `LIGHT_THEME` which was merged with eui theme overrides. These new themes are now default. * **axis:** Now respects `tickLine.padding` whenever `tickLine.visible` is `true`
This was referenced Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These changes merge the original charts-owned themes with the eui-owned charts themes.
Details
Deep merge of
LIGHT_THEMEwithEUI_CHARTS_THEME_LIGHTandDARK_THEMEwithEUI_CHARTS_THEME_DARK.VRT Changes due to
Padding changes WRT overall chart paddingfixed with temporary theme overridePadding changes particularly WRTFixed with fix(axis): always rendertickLinewhich is now hidden by default. This caused thetickLinepadding to not be applied even when forced totrueas it requires a non-zero tick size. This is fixed in each case by enabling thetickLineand setting a finite value for the tick size.tickLineunlessvisibleisfalse#2194Issues
Step 1 in #2069
Checklist
:xy,:partition):interactions,:axis)closes #123,fixes #123)dark,light,eui-dark&eui-light