Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change baseThemeType to baseTheme #292

Closed
cchaos opened this issue Aug 6, 2019 · 1 comment
Closed

Change baseThemeType to baseTheme #292

cchaos opened this issue Aug 6, 2019 · 1 comment
Assignees
@nickofthyme
Labels
enhancement New feature or request released Issue released publicly :styling Styling related issue

Comments

@cchaos
Copy link
Contributor

cchaos commented Aug 6, 2019

Is your feature request related to a problem? Please describe.
I've created two EUI specific themes for light and dark which Kibana should use as a consumer of EUI. However, the new baseThemeType doesn't take into account a custom theme. Therefore it's still hard to combine a partial theme with a custom theme. Still have to use mergeWithDefaultTheme.

Describe the solution you'd like
Change baseThemeType to be baseTheme which accepts a custom theme object.
@cchaos cchaos added enhancement New feature or request :styling Styling related issue labels Aug 6, 2019
@nickofthyme nickofthyme self-assigned this Aug 20, 2019
nickofthyme added a commit to nickofthyme/elastic-charts that referenced this issue Aug 20, 2019
@nickofthyme
feat(theme): base theme prop
e3ff483 
Allow baseTheme prop to override baseThemeType prop

elastic#292
@nickofthyme nickofthyme mentioned this issue Aug 20, 2019
Merged
2 tasks
nickofthyme added a commit that referenced this issue Aug 21, 2019
@nickofthyme
feat(theme): base theme prop (#333)
a9ff5e1 
* Allow `baseTheme` prop to set base theme, default is still `LIGHT_THEME`
* refactor: theme type logic

BREAKING CHANGE: remove `baseThemeType` prop on `Settings` component and `BaseThemeTypes` type.

#292
markov00 pushed a commit that referenced this issue Aug 21, 2019
@semantic-release-bot
chore(release): 10.0.0 [skip ci]
b756116 
# [10.0.0](v9.2.1...v10.0.0) (2019-08-21)

### Bug Fixes

* **tooltip:** ie11 flex sizing ([#334](#334)) ([abaa472](abaa472)), closes [#332](#332)
* decuple brush cursor from chart rendering ([#331](#331)) ([789f85a](789f85a)), closes [elastic/kibana#36517](elastic/kibana#36517)
* remove clippings from chart geometries ([#320](#320)) ([ed6d0e5](ed6d0e5)), closes [#20](#20)

### Features

* auto legend resize ([#316](#316)) ([659d27e](659d27e)), closes [#268](#268)
* customize number of axis ticks ([#319](#319)) ([2b838d7](2b838d7))
* **theme:** base theme prop ([#333](#333)) ([a9ff5e1](a9ff5e1)), closes [#292](#292)

### BREAKING CHANGES

* **theme:** remove `baseThemeType` prop on `Settings` component and `BaseThemeTypes` type.
* `theme.legend.spacingBuffer` added to `Theme` type. Controls the width buffer between the legend label and value.
@markov00 markov00 added the released Issue released publicly label Aug 21, 2019
@markov00
Copy link
Member

🎉 This issue has been resolved in version 10.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 10.0.0 [skip ci]
e7eb49c 
# [10.0.0](elastic/elastic-charts@v9.2.1...v10.0.0) (2019-08-21)

### Bug Fixes

* **tooltip:** ie11 flex sizing ([opensearch-project#334](elastic/elastic-charts#334)) ([2683333](elastic/elastic-charts@2683333)), closes [opensearch-project#332](elastic/elastic-charts#332)
* decuple brush cursor from chart rendering ([opensearch-project#331](elastic/elastic-charts#331)) ([b5b8dde](elastic/elastic-charts@b5b8dde)), closes [elastic/kibana#36517](elastic/kibana#36517)
* remove clippings from chart geometries ([opensearch-project#320](elastic/elastic-charts#320)) ([497efa4](elastic/elastic-charts@497efa4)), closes [opensearch-project#20](elastic/elastic-charts#20)

### Features

* auto legend resize ([opensearch-project#316](elastic/elastic-charts#316)) ([be4a53d](elastic/elastic-charts@be4a53d)), closes [opensearch-project#268](elastic/elastic-charts#268)
* customize number of axis ticks ([opensearch-project#319](elastic/elastic-charts#319)) ([a7a4ecd](elastic/elastic-charts@a7a4ecd))
* **theme:** base theme prop ([opensearch-project#333](elastic/elastic-charts#333)) ([0b38770](elastic/elastic-charts@0b38770)), closes [opensearch-project#292](elastic/elastic-charts#292)

### BREAKING CHANGES

* **theme:** remove `baseThemeType` prop on `Settings` component and `BaseThemeTypes` type.
* `theme.legend.spacingBuffer` added to `Theme` type. Controls the width buffer between the legend label and value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickofthyme nickofthyme

Labels
enhancement New feature or request released Issue released publicly :styling Styling related issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cchaos @markov00 @nickofthyme