Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): ie11 flex sizing #334

Merged
merged 3 commits into from
Aug 21, 2019

Conversation

nickofthyme
Copy link
Collaborator

@nickofthyme nickofthyme commented Aug 20, 2019

Summary

Fix tooltip flex positioning issue. #332

For some reason the default flex in Chrome/Firefox is different from IE.

// default in Crome
.class {
  flex: 1 1 auto;
}

// default in IE
.class {
  flex: 1 1 0;
}

In the future use flex: 1 1 auto instead of flex: 1 for row elements that you want to occupare the remaining space. This is not the same for column elements as safari will not occupare the space.

Also added playground:ie script to start playground webpack server on local ip.

Chrome

Screen Recording 2019-08-20 at 03 51 PM

IE 11

Screen Recording 2019-08-20 at 03 53 PM

Checklist

@nickofthyme nickofthyme added bug Something isn't working :styling Styling related issue labels Aug 20, 2019
@nickofthyme nickofthyme requested a review from markov00 August 20, 2019 21:07
@nickofthyme
Copy link
Collaborator Author

@markov00 I noticed that the error of the work break in IE11 still cuts words up. Is there an issue yet in EUI for that, relating to the euiTextOverflowWrap mixin?

image

@codecov-io
Copy link

codecov-io commented Aug 20, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@659d27e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #334   +/-   ##
=========================================
  Coverage          ?   98.51%           
=========================================
  Files             ?       38           
  Lines             ?     2698           
  Branches          ?      635           
=========================================
  Hits              ?     2658           
  Misses            ?       37           
  Partials          ?        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 659d27e...bf968e4. Read the comment docs.

Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Tested on IE11 works good.
For the euiTextoverflow thing. on this PR https://github.com/elastic/kibana/pull/41703/files we removed that in favour or this:

overflow-wrap: break-word;
word-wrap: break-word;

@nickofthyme
Copy link
Collaborator Author

nickofthyme commented Aug 21, 2019

@markov00 I'll just fix it then

image

@nickofthyme nickofthyme merged commit abaa472 into elastic:master Aug 21, 2019
markov00 pushed a commit that referenced this pull request Aug 21, 2019
# [10.0.0](v9.2.1...v10.0.0) (2019-08-21)

### Bug Fixes

* **tooltip:** ie11 flex sizing ([#334](#334)) ([abaa472](abaa472)), closes [#332](#332)
* decuple brush cursor from chart rendering ([#331](#331)) ([789f85a](789f85a)), closes [elastic/kibana#36517](elastic/kibana#36517)
* remove clippings from chart geometries ([#320](#320)) ([ed6d0e5](ed6d0e5)), closes [#20](#20)

### Features

* auto legend resize ([#316](#316)) ([659d27e](659d27e)), closes [#268](#268)
* customize number of axis ticks ([#319](#319)) ([2b838d7](2b838d7))
* **theme:** base theme prop ([#333](#333)) ([a9ff5e1](a9ff5e1)), closes [#292](#292)

### BREAKING CHANGES

* **theme:** remove `baseThemeType` prop on `Settings` component and `BaseThemeTypes` type.
* `theme.legend.spacingBuffer` added to `Theme` type. Controls the width buffer between the legend label and value.
@markov00
Copy link
Member

🎉 This PR is included in version 10.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Aug 21, 2019
@nickofthyme nickofthyme deleted the fix/tooltip-ie branch August 26, 2019 19:59
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
# [10.0.0](elastic/elastic-charts@v9.2.1...v10.0.0) (2019-08-21)

### Bug Fixes

* **tooltip:** ie11 flex sizing ([opensearch-project#334](elastic/elastic-charts#334)) ([2683333](elastic/elastic-charts@2683333)), closes [opensearch-project#332](elastic/elastic-charts#332)
* decuple brush cursor from chart rendering ([opensearch-project#331](elastic/elastic-charts#331)) ([b5b8dde](elastic/elastic-charts@b5b8dde)), closes [elastic/kibana#36517](elastic/kibana#36517)
* remove clippings from chart geometries ([opensearch-project#320](elastic/elastic-charts#320)) ([497efa4](elastic/elastic-charts@497efa4)), closes [opensearch-project#20](elastic/elastic-charts#20)

### Features

* auto legend resize ([opensearch-project#316](elastic/elastic-charts#316)) ([be4a53d](elastic/elastic-charts@be4a53d)), closes [opensearch-project#268](elastic/elastic-charts#268)
* customize number of axis ticks ([opensearch-project#319](elastic/elastic-charts#319)) ([a7a4ecd](elastic/elastic-charts@a7a4ecd))
* **theme:** base theme prop ([opensearch-project#333](elastic/elastic-charts#333)) ([0b38770](elastic/elastic-charts@0b38770)), closes [opensearch-project#292](elastic/elastic-charts#292)

### BREAKING CHANGES

* **theme:** remove `baseThemeType` prop on `Settings` component and `BaseThemeTypes` type.
* `theme.legend.spacingBuffer` added to `Theme` type. Controls the width buffer between the legend label and value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released Issue released publicly :styling Styling related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants