Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hideInLegend doesn't work #306

Closed
2 tasks done
nickofthyme opened this issue Aug 13, 2019 · 1 comment · Fixed by #307 or elastic/kibana#43516
Closed
2 tasks done

hideInLegend doesn't work #306

nickofthyme opened this issue Aug 13, 2019 · 1 comment · Fixed by #307 or elastic/kibana#43516
Labels
bug Something isn't working released Issue released publicly

Comments

@nickofthyme
Copy link
Collaborator

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://elastic.github.io/elastic-charts/?path=/story/legend--hide-legend-items-by-series
  2. Toggle either legend knob
  3. See no change in the legend items being displayed

Expected behavior
Hidden legend item should not show per #147

Screenshots
Screen Recording 2019-08-12 at 07 49 PM

Version (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Elastic Charts: [e.g. 1.0.1]

Additional context
Add any other context about the problem here.

Errors in browser console
If applicable, add any console error.

Kibana Cross Issues
Add any Kibana related issues here.

Checklist

  • every related Kibana issue is listed under Kibana Cross Issues list
  • kibana cross issue tag is associated to the issue if any kibana cross issue is present
@nickofthyme nickofthyme added the bug Something isn't working label Aug 13, 2019
nickofthyme added a commit to nickofthyme/elastic-charts that referenced this issue Aug 13, 2019
@nickofthyme
fix(legend): item hideInLegend prop
55586dd 
Fix hideInLegend prop to work again

fix elastic#306
@nickofthyme nickofthyme mentioned this issue Aug 13, 2019
Merged
2 tasks
nickofthyme added a commit that referenced this issue Aug 13, 2019
@nickofthyme
fix(legend): item hideInLegend prop (#307)
3aa5ca3 
Fix `hideInLegend` prop to work again

fix #306
markov00 pushed a commit that referenced this issue Aug 13, 2019
@semantic-release-bot
chore(release): 9.0.4 [skip ci]
d24a852 
## [9.0.4](v9.0.3...v9.0.4) (2019-08-13)

### Bug Fixes

* **legend:** item hideInLegend prop ([#307](#307)) ([3aa5ca3](3aa5ca3)), closes [#306](#306)
@markov00
Copy link
Member

🎉 This issue has been resolved in version 9.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Aug 13, 2019
@alexwizp alexwizp mentioned this issue Aug 19, 2019
Merged
7 tasks
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 9.0.4 [skip ci]
42d95b6 
## [9.0.4](elastic/elastic-charts@v9.0.3...v9.0.4) (2019-08-13)

### Bug Fixes

* **legend:** item hideInLegend prop ([opensearch-project#307](elastic/elastic-charts#307)) ([fdfc694](elastic/elastic-charts@fdfc694)), closes [opensearch-project#306](elastic/elastic-charts#306)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released Issue released publicly
Projects
None yet
Milestone
No milestone
2 participants
@markov00 @nickofthyme