Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(legend): hide legend item if hideLegendItem on series spec is true #147

Merged
merged 6 commits into from
Apr 4, 2019

Conversation

emmacunningham
Copy link
Contributor

Summary

close #137

This PR introduces a new property to the series spec hideInLegend which, when true, will remove the legend item from being visible in the legend list.

hide_legend_item

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

  • This was checked for cross-browser compatibility, including a check against IE11
  • Proper documentation or storybook story was added for features that require explanation or tutorials
  • Unit tests were updated or added to match the most common scenarios
  • Each commit follows the convention

@codecov-io
Copy link

codecov-io commented Apr 3, 2019

Codecov Report

Merging #147 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #147      +/-   ##
==========================================
+ Coverage    92.9%   92.91%   +<.01%     
==========================================
  Files          33       33              
  Lines        1495     1497       +2     
  Branches      166      167       +1     
==========================================
+ Hits         1389     1391       +2     
  Misses         92       92              
  Partials       14       14
Impacted Files Coverage Δ
src/lib/series/specs.ts 100% <ø> (ø) ⬆️
src/lib/series/legend.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34d676a...12b5fb1. Read the comment docs.

@emmacunningham emmacunningham requested a review from markov00 April 3, 2019 22:50
@markov00 markov00 mentioned this pull request Apr 3, 2019
93 tasks
Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Tested locally on chrome

@markov00 markov00 added :legend Legend related issue enhancement New feature or request labels Apr 4, 2019
@emmacunningham emmacunningham merged commit 6761c2b into elastic:master Apr 4, 2019
markov00 pushed a commit that referenced this pull request Apr 4, 2019
# [3.7.0](v3.6.0...v3.7.0) (2019-04-04)

### Features

* **legend:** hide legend item if hideLegendItem on series spec is true ([#147](#147)) ([6761c2b](6761c2b))
@markov00
Copy link
Member

markov00 commented Apr 4, 2019

🎉 This PR is included in version 3.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Apr 4, 2019
@nickofthyme nickofthyme mentioned this pull request Aug 13, 2019
2 tasks
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
# [3.7.0](elastic/elastic-charts@v3.6.0...v3.7.0) (2019-04-04)

### Features

* **legend:** hide legend item if hideLegendItem on series spec is true ([opensearch-project#147](elastic/elastic-charts#147)) ([57c4fda](elastic/elastic-charts@57c4fda))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request :legend Legend related issue released Issue released publicly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possibility to hide a series in the legend
3 participants