Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(legend): hide legend item if hideLegendItem on series spec is true #147

Merged
merged 6 commits into from
Apr 4, 2019
Merged

feat(legend): hide legend item if hideLegendItem on series spec is true #147

merged 6 commits into from
Apr 4, 2019

Commits on Apr 3, 2019

  1. feat(specs): add hideInLegend to spec props

    @emmacunningham
    emmacunningham committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    8f6c1aa View commit details
    Browse the repository at this point in the history

  2. refactor(legend): change series visibility property to isSeriesVisible

    @emmacunningham
    emmacunningham committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    7588fae View commit details
    Browse the repository at this point in the history

  3. test: update specs in tests with new property

    @emmacunningham
    emmacunningham committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    8ad5662 View commit details
    Browse the repository at this point in the history

  4. feat(legend): hide legend item if spec hideInLegend true

    @emmacunningham
    emmacunningham committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    062f2cb View commit details
    Browse the repository at this point in the history

  5. fix(spec): make hideInLegend optional (defaults to false anyway)

    @emmacunningham
    emmacunningham committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    bf05161 View commit details
    Browse the repository at this point in the history

  6. refactor(legend): refactor spec check to occur with label check

    @emmacunningham
    emmacunningham committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    12b5fb1 View commit details
    Browse the repository at this point in the history