Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make legend in charts selectable #710

Closed
timroes opened this issue Jun 15, 2020 · 7 comments · Fixed by #877
Closed

Make legend in charts selectable #710

timroes opened this issue Jun 15, 2020 · 7 comments · Fixed by #877
Labels
discuss To be discussed enhancement New feature or request :legend Legend related issue released Issue released publicly

Comments

@timroes
Copy link

timroes commented Jun 15, 2020

We currently use user-select: none on the legend in elastic charts. I've heard from users, that they would like to select the element items to copy and paste (e.g. there is a legend of ip addresses). I think it's worth discussing if the use-case of copying values from the legend wouldn't be worth keeping the legend selectable.

@timroes timroes added enhancement New feature or request discuss To be discussed labels Jun 15, 2020
@archon810
Copy link

I'm one such user. I had to resort to using this extension to override this for now https://chrome.google.com/webstore/detail/absolute-enable-right-cli/jdocbkpgdakpekjlhemmfcncgdjeiika.

Before finding this solution, I also resorted to using tables for IP lists. I can easily copy from tables without any hacks.

@nickofthyme
Copy link
Collaborator

nickofthyme commented Jun 16, 2020

That's a reasonable ask. I believe we added that because they are typically clickable and clicking them twice would tend to highlight all legend items. But this is purely cosmetic and we can change this if desired.

@unixsurfer
Copy link

It is very common for system engineers to select a certain legend and paste it into ssh cmd for instance. During an incident for instance, this is what we need to do most of the time.
Currently, the only way I know to workaround this limitation is to open develop mode in the browser and find the value of the legend from there.

@markov00 markov00 mentioned this issue Aug 6, 2020
@markov00
Copy link
Member

markov00 commented Aug 6, 2020

As described in chat, one possible way to solve this is to add an action to copy the legend item text through a contextual menu. We have a task about redesign the legend that will take in consideration also a better way to select the text and a way to display fully the text on the legend

@unixsurfer
Copy link

As described in chat, one possible way to solve this is to add an action to copy the legend item text through a contextual menu. We have a task about redesign the legend that will take in consideration also a better way to select the text and a way to display fully the text on the legend

I am fine with this approach. Thank you.

@archon810
Copy link

That sounds good. The action can appear on hover to about cluttering the UI.

@markov00 markov00 added this to the Kibana 7.11 milestone Aug 26, 2020
@markov00 markov00 mentioned this issue Oct 7, 2020
7 tasks
@markov00 markov00 added the :legend Legend related issue label Oct 7, 2020
markov00 pushed a commit that referenced this issue Nov 24, 2020
# [24.1.0](v24.0.0...v24.1.0) (2020-11-24)

### Bug Fixes

* **area_charts:** correctly represent baseline with negative data points ([#896](#896)) ([d1243f1](d1243f1))
* **legend:** legend sizes with ordinal data ([#867](#867)) ([7559e0d](7559e0d)), closes [#811](#811)
* render orphan data points on lines and areas ([#900](#900)) ([0be282b](0be282b)), closes [#783](#783)
* specs swaps correctly reflected in state ([#901](#901)) ([7fba882](7fba882))

### Features

* **legend:** allow legend text to be copyable ([#877](#877)) ([9cd3459](9cd3459)), closes [#710](#710)
* allow clearing series colors from memory ([#899](#899)) ([ab1af38](ab1af38))
* merge series domain with the domain of another group ([#912](#912)) ([325b013](325b013))
* small multiples for XY charts (alpha) ([#793](#793)) ([d288208](d288208)), closes [#500](#500) [#500](#500)
@markov00
Copy link
Member

🎉 This issue has been resolved in version 24.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Nov 24, 2020
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
# [24.1.0](elastic/elastic-charts@v24.0.0...v24.1.0) (2020-11-24)

### Bug Fixes

* **area_charts:** correctly represent baseline with negative data points ([opensearch-project#896](elastic/elastic-charts#896)) ([b622fda](elastic/elastic-charts@b622fda))
* **legend:** legend sizes with ordinal data ([opensearch-project#867](elastic/elastic-charts#867)) ([74bcbad](elastic/elastic-charts@74bcbad)), closes [opensearch-project#811](elastic/elastic-charts#811)
* render orphan data points on lines and areas ([opensearch-project#900](elastic/elastic-charts#900)) ([3e2c739](elastic/elastic-charts@3e2c739)), closes [opensearch-project#783](elastic/elastic-charts#783)
* specs swaps correctly reflected in state ([opensearch-project#901](elastic/elastic-charts#901)) ([a94347f](elastic/elastic-charts@a94347f))

### Features

* **legend:** allow legend text to be copyable ([opensearch-project#877](elastic/elastic-charts#877)) ([21a96d3](elastic/elastic-charts@21a96d3)), closes [opensearch-project#710](elastic/elastic-charts#710)
* allow clearing series colors from memory ([opensearch-project#899](elastic/elastic-charts#899)) ([e97f4ab](elastic/elastic-charts@e97f4ab))
* merge series domain with the domain of another group ([opensearch-project#912](elastic/elastic-charts#912)) ([716ad5a](elastic/elastic-charts@716ad5a))
* small multiples for XY charts (alpha) ([opensearch-project#793](elastic/elastic-charts#793)) ([3b88e1c](elastic/elastic-charts@3b88e1c)), closes [opensearch-project#500](elastic/elastic-charts#500) [opensearch-project#500](elastic/elastic-charts#500)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss To be discussed enhancement New feature or request :legend Legend related issue released Issue released publicly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants