Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display orphan data points on line/area charts also if the point style is invisible #783

Closed
AlonaNadler opened this issue Aug 13, 2020 · 2 comments · Fixed by #900
Closed

Display orphan data points on line/area charts also if the point style is invisible #783

AlonaNadler opened this issue Aug 13, 2020 · 2 comments · Fixed by #900
Assignees
@markov00
Labels
bug Something isn't working :chart Chart element related issue released Issue released publicly :xy Bar/Line/Area chart related

Comments

@AlonaNadler
Copy link

I heard from Lens team this is how Elastic chart displays, so opening this issue here
image

When in Lens and with sparse data the dops/points on the chart shows empty even though once her on them they have value
The behavior doesn't make sense
@AlonaNadler AlonaNadler added the bug Something isn't working label Aug 13, 2020
@markov00 markov00 changed the title point value shows empty Display orphan data points on line/area charts also if the point style is invisible Aug 13, 2020
@markov00 markov00 added :chart Chart element related issue :xy Bar/Line/Area chart related labels Aug 13, 2020
@markov00
Copy link
Member

markov00 commented Aug 13, 2020 •
edited
Loading

I think this was left behind due to the premature closing of this issue: #63
Right now, it's only possible to show orphan data points of a line/area chart only if we have the point style of that chart type set to visible.
We should be able to identify these data points and mark then as visible, independently from their current style

@markov00 markov00 added this to the Kibana 7.11 milestone Aug 26, 2020
@markov00 markov00 mentioned this issue Nov 11, 2020
Merged
2 tasks
markov00 added a commit that referenced this issue Nov 12, 2020
@markov00
fix: render orphan data points on lines and areas (#900)
0be282b 
This commits adds the ability to render orphan data points displayed on a line or area chart. An orphan data point is a datapoint that doesn't have a next or a previous data point to connect to.

fix #783
markov00 pushed a commit that referenced this issue Nov 24, 2020
@semantic-release-bot
chore(release): 24.1.0 [skip ci]
f99ba1f 
# [24.1.0](v24.0.0...v24.1.0) (2020-11-24)

### Bug Fixes

* **area_charts:** correctly represent baseline with negative data points ([#896](#896)) ([d1243f1](d1243f1))
* **legend:** legend sizes with ordinal data ([#867](#867)) ([7559e0d](7559e0d)), closes [#811](#811)
* render orphan data points on lines and areas ([#900](#900)) ([0be282b](0be282b)), closes [#783](#783)
* specs swaps correctly reflected in state ([#901](#901)) ([7fba882](7fba882))

### Features

* **legend:** allow legend text to be copyable ([#877](#877)) ([9cd3459](9cd3459)), closes [#710](#710)
* allow clearing series colors from memory ([#899](#899)) ([ab1af38](ab1af38))
* merge series domain with the domain of another group ([#912](#912)) ([325b013](325b013))
* small multiples for XY charts (alpha) ([#793](#793)) ([d288208](d288208)), closes [#500](#500) [#500](#500)
@markov00
Copy link
Member

🎉 This issue has been resolved in version 24.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Nov 24, 2020
@markov00 markov00 self-assigned this Nov 25, 2020
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 24.1.0 [skip ci]
b4aa26a 
# [24.1.0](elastic/elastic-charts@v24.0.0...v24.1.0) (2020-11-24)

### Bug Fixes

* **area_charts:** correctly represent baseline with negative data points ([opensearch-project#896](elastic/elastic-charts#896)) ([b622fda](elastic/elastic-charts@b622fda))
* **legend:** legend sizes with ordinal data ([opensearch-project#867](elastic/elastic-charts#867)) ([74bcbad](elastic/elastic-charts@74bcbad)), closes [opensearch-project#811](elastic/elastic-charts#811)
* render orphan data points on lines and areas ([opensearch-project#900](elastic/elastic-charts#900)) ([3e2c739](elastic/elastic-charts@3e2c739)), closes [opensearch-project#783](elastic/elastic-charts#783)
* specs swaps correctly reflected in state ([opensearch-project#901](elastic/elastic-charts#901)) ([a94347f](elastic/elastic-charts@a94347f))

### Features

* **legend:** allow legend text to be copyable ([opensearch-project#877](elastic/elastic-charts#877)) ([21a96d3](elastic/elastic-charts@21a96d3)), closes [opensearch-project#710](elastic/elastic-charts#710)
* allow clearing series colors from memory ([opensearch-project#899](elastic/elastic-charts#899)) ([e97f4ab](elastic/elastic-charts@e97f4ab))
* merge series domain with the domain of another group ([opensearch-project#912](elastic/elastic-charts#912)) ([716ad5a](elastic/elastic-charts@716ad5a))
* small multiples for XY charts (alpha) ([opensearch-project#793](elastic/elastic-charts#793)) ([3b88e1c](elastic/elastic-charts@3b88e1c)), closes [opensearch-project#500](elastic/elastic-charts#500) [opensearch-project#500](elastic/elastic-charts#500)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markov00 markov00

Labels
bug Something isn't working :chart Chart element related issue released Issue released publicly :xy Bar/Line/Area chart related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: render orphan data points on lines and areas markov00/elastic-charts
2 participants
@markov00 @AlonaNadler