Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rect annotations can display beyond the chart area #832

Closed
nickofthyme opened this issue Sep 23, 2020 · 1 comment · Fixed by #841
Closed

Rect annotations can display beyond the chart area #832

nickofthyme opened this issue Sep 23, 2020 · 1 comment · Fixed by #841
Assignees
@markov00
Labels
:annotation Annotation (line, rect, text) related issue bug Something isn't working released Issue released publicly

Comments

@nickofthyme
Copy link
Collaborator

nickofthyme commented Sep 23, 2020 •
edited
Loading

Describe the bug
RectAnnotation can display beyond the chart area

To Reproduce
Steps to reproduce the behavior:

  1. Add RectAnnotation with a x0 value that goes beyond the end of the domain.
  2. Notice the annotation rendered beyond the chart area.

Expected behaviour
A clear and concise description of what you expected to happen.

Screenshots
Image 2020-09-23 at 7 57 34 AM

image

image

Version (please complete the following information):

  • Elastic Charts: latest
@nickofthyme nickofthyme added bug Something isn't working :annotation Annotation (line, rect, text) related issue labels Sep 23, 2020
@markov00 markov00 self-assigned this Sep 30, 2020
@markov00 markov00 mentioned this issue Oct 1, 2020
Merged
1 task
markov00 added a commit that referenced this issue Oct 2, 2020
@markov00
fix: limit annotation to the current domain extent (#841)
4186962 
This commit fixes the domain extent limiting function when rendering annotations avoiding overflows when the user input falls outside the current computed or configured data domain.

fix #832
markov00 pushed a commit that referenced this issue Oct 5, 2020
@semantic-release-bot
chore(release): 23.1.1 [skip ci]
d4aa7c8 
## [23.1.1](v23.1.0...v23.1.1) (2020-10-05)

### Bug Fixes

* limit annotation to the current domain extent ([#841](#841)) ([4186962](4186962)), closes [#832](#832)
@markov00
Copy link
Member

markov00 commented Oct 5, 2020

🎉 This issue has been resolved in version 23.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Oct 5, 2020
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 23.1.1 [skip ci]
5e221a4 
## [23.1.1](elastic/elastic-charts@v23.1.0...v23.1.1) (2020-10-05)

### Bug Fixes

* limit annotation to the current domain extent ([opensearch-project#841](elastic/elastic-charts#841)) ([7e85a43](elastic/elastic-charts@7e85a43)), closes [#832](elastic/elastic-charts#832)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markov00 markov00

Labels
:annotation Annotation (line, rect, text) related issue bug Something isn't working released Issue released publicly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: limit annotation to the current domain extent markov00/elastic-charts
2 participants
@markov00 @nickofthyme