Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: limit annotation to the current domain extent #841

Merged
merged 6 commits into from
Oct 2, 2020
Merged

fix: limit annotation to the current domain extent #841

merged 6 commits into from
Oct 2, 2020

Conversation

markov00
Copy link
Member

@markov00 markov00 commented Oct 1, 2020 •
edited
Loading

Summary

Fixes the domain extent limiting function when rendering annotations avoiding overflows when the user input falls outside the current computed or configured data domain.

Before:

Screenshot 2020-10-01 at 22 35 33

After:

Screenshot 2020-10-01 at 22 53 29

fix #832

Checklist

  • Unit tests were updated or added to match the most common scenarios

@markov00 markov00 marked this pull request as ready for review October 1, 2020 20:56
@markov00 markov00 added :annotation Annotation (line, rect, text) related issue :xy Bar/Line/Area chart related bug Something isn't working labels Oct 1, 2020
nickofthyme
nickofthyme approved these changes Oct 2, 2020
View reviewed changes
Copy link
Collaborator

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and issue is now fixed.

image

@markov00 markov00 merged commit 4186962 into elastic:master Oct 2, 2020
@markov00 markov00 deleted the 2020_09_30-fix_annotation_out_of_domain branch October 2, 2020 16:30
markov00 pushed a commit that referenced this pull request Oct 5, 2020
@semantic-release-bot
chore(release): 23.1.1 [skip ci]
d4aa7c8 
## [23.1.1](v23.1.0...v23.1.1) (2020-10-05)

### Bug Fixes

* limit annotation to the current domain extent ([#841](#841)) ([4186962](4186962)), closes [#832](#832)
@markov00
Copy link
Member Author

markov00 commented Oct 5, 2020

🎉 This PR is included in version 23.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Oct 5, 2020
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
@semantic-release-bot
chore(release): 23.1.1 [skip ci]
5e221a4 
## [23.1.1](elastic/elastic-charts@v23.1.0...v23.1.1) (2020-10-05)

### Bug Fixes

* limit annotation to the current domain extent ([opensearch-project#841](elastic/elastic-charts#841)) ([7e85a43](elastic/elastic-charts@7e85a43)), closes [#832](elastic/elastic-charts#832)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickofthyme nickofthyme nickofthyme approved these changes

@rshen91 rshen91 Awaiting requested review from rshen91

Assignees
No one assigned
Labels
:annotation Annotation (line, rect, text) related issue bug Something isn't working released Issue released publicly :xy Bar/Line/Area chart related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rect annotations can display beyond the chart area
2 participants
@markov00 @nickofthyme