Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable click on the whole bucket #846

Closed
cauemarcondes opened this issue Oct 5, 2020 · 2 comments · Fixed by #913
Closed

Enable click on the whole bucket #846

cauemarcondes opened this issue Oct 5, 2020 · 2 comments · Fixed by #913
Assignees
@markov00
Labels
enhancement New feature or request :interactions Interactions related issue released Issue released publicly :xy Bar/Line/Area chart related

Comments

@cauemarcondes
Copy link

Is your feature request related to a problem? Please describe.
When the difference between buckets is too big on a Bar chart, clicking on a bucket is very difficult as shown in the gif below.

charts-bar-click

Describe the solution you'd like
I would like to have the whole bucket area clickable.

Screenshot 2020-10-05 at 17 01 02
@cauemarcondes cauemarcondes added the enhancement New feature or request label Oct 5, 2020
@markov00 markov00 mentioned this issue Oct 7, 2020
Open
4 tasks
@markov00 markov00 added :interactions Interactions related issue :xy Bar/Line/Area chart related labels Oct 7, 2020
@cauemarcondes cauemarcondes mentioned this issue Oct 20, 2020
Merged
5 tasks
@nickofthyme nickofthyme added this to the Kibana 7.11 milestone Oct 29, 2020
@formgeist
Copy link

@nickofthyme Greetings! I just wanted to raise this issue because we're quite dependent on this usability in our distribution chart in APM, and it would be great to resolve this before shipping 7.11 so we can test the clickable container. Are you still confident in shipping this for 7.11?

I put together a list of blockers and polish for the APM team here elastic/kibana#84178 with some more context.

@formgeist formgeist mentioned this issue Nov 24, 2020
Closed
10 tasks
@markov00 markov00 self-assigned this Nov 24, 2020
markov00 added a commit to markov00/elastic-charts that referenced this issue Nov 24, 2020
@markov00
feat: add projection click listener
12f0299 
close elastic#846
@markov00 markov00 mentioned this issue Nov 24, 2020
Merged
3 tasks
markov00 added a commit that referenced this issue Nov 25, 2020
@markov00
feat: add projection click listener (#913)
0fa9072 
This commits adds a projection click listener called onProjectionListener and available in the <Settings /> component with the following characteristics:
- it will fire every time the user clicks on the projection area (everything within the axes)
- the listener is called with an object that contains the nearest X and Ys values. These values are not screen coordinates but the real data domain values inverted computed inverting the x and y scales.
- we prevent the onProjectionListener from firing an event if a onElementClick listener is available and it has fired a click event

close #846
markov00 pushed a commit that referenced this issue Nov 25, 2020
@semantic-release-bot
chore(release): 24.2.0 [skip ci]
6bad227 
# [24.2.0](v24.1.0...v24.2.0) (2020-11-25)

### Bug Fixes

* near and far alignments for orthogonal rotations ([#911](#911)) ([cb279f3](cb279f3))

### Features

* add projection click listener ([#913](#913)) ([0fa9072](0fa9072)), closes [#846](#846)
@markov00
Copy link
Member

🎉 This issue has been resolved in version 24.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Nov 25, 2020
@cauemarcondes cauemarcondes mentioned this issue Nov 26, 2020
Merged
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 24.2.0 [skip ci]
1d24233 
# [24.2.0](elastic/elastic-charts@v24.1.0...v24.2.0) (2020-11-25)

### Bug Fixes

* near and far alignments for orthogonal rotations ([opensearch-project#911](elastic/elastic-charts#911)) ([6b162c6](elastic/elastic-charts@6b162c6))

### Features

* add projection click listener ([opensearch-project#913](elastic/elastic-charts#913)) ([19c14e4](elastic/elastic-charts@19c14e4)), closes [opensearch-project#846](elastic/elastic-charts#846)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markov00 markov00

Labels
enhancement New feature or request :interactions Interactions related issue released Issue released publicly :xy Bar/Line/Area chart related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add projection click listener markov00/elastic-charts
4 participants
@markov00 @formgeist @nickofthyme @cauemarcondes