Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.1] Ensure DCO Workflow Check #846

Merged
merged 1 commit into from
Oct 5, 2021
Merged

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Oct 5, 2021

Issue Resolved:
#834

Backport PR:
#841

Signed-off-by: Anan Zhuang ananzh@amazon.com

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

Issue Resolved:
opensearch-project#834

Backport PR:
opensearch-project#841

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh ananzh added enhancement New feature or request v1.1.0 backport labels Oct 5, 2021
@ananzh ananzh self-assigned this Oct 5, 2021
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed f30030c

@ananzh ananzh merged commit 3e6d39e into opensearch-project:1.1 Oct 5, 2021
@ananzh ananzh deleted the 1.1-DCO branch October 6, 2021 14:43
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
This commits adds a projection click listener called onProjectionListener and available in the <Settings /> component with the following characteristics:
- it will fire every time the user clicks on the projection area (everything within the axes)
- the listener is called with an object that contains the nearest X and Ys values. These values are not screen coordinates but the real data domain values inverted computed inverting the x and y scales.
- we prevent the onProjectionListener from firing an event if a onElementClick listener is available and it has fired a click event

close opensearch-project#846
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v1.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants