-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(specs): add name to series specs #142
Conversation
A `name` prop is now available for each series. This name will be used, if available, on every legend or tooltip instead of the specId (used as fallback). fix elastic#136
Codecov Report
@@ Coverage Diff @@
## master #142 +/- ##
=======================================
Coverage 92.84% 92.84%
=======================================
Files 31 31
Lines 1481 1481
Branches 163 166 +3
=======================================
Hits 1375 1375
Misses 92 92
Partials 14 14
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested locally on Firefox & code LGTM
🎉 This PR is included in version 3.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# [3.5.0](elastic/elastic-charts@v3.4.5...v3.5.0) (2019-04-01) ### Bug Fixes * **areachart:** fix misaligned rendering props ([opensearch-project#141](elastic/elastic-charts#141)) ([d627f4d](elastic/elastic-charts@d627f4d)), closes [opensearch-project#140](elastic/elastic-charts#140) ### Features * **specs:** add name to series specs ([opensearch-project#142](elastic/elastic-charts#142)) ([c045eee](elastic/elastic-charts@c045eee)), closes [opensearch-project#136](elastic/elastic-charts#136)
Summary
fix #136
A
name
prop is now available for each series. This name will be used, if available, on everylegend or tooltip instead of the specId (used as fallback).
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.