Fixed use of dictionaries as values in Terms query (#1921) (#1922)

Fixes #1920
elastic · Oct 7, 2024 · e49d851 · e49d851
1 parent 3f072c3
commit e49d851
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/elasticsearch_dsl/query.py b/elasticsearch_dsl/query.py
@@ -552,7 +552,7 @@ class Terms(Query):
 
     def _setattr(self, name: str, value: Any) -> None:
         # here we convert any iterables that are not strings to lists
-        if hasattr(value, "__iter__") and not isinstance(value, (str, list)):
+        if hasattr(value, "__iter__") and not isinstance(value, (str, list, dict)):
             value = list(value)
         super()._setattr(name, value)
 

diff --git a/tests/test_query.py b/tests/test_query.py
@@ -84,6 +84,14 @@ def test_terms_to_dict() -> None:
     assert {"terms": {"_type": ["article", "section"], "boost": 1.1}} == query.Terms(
         _type=("article", "section"), boost=1.1
     ).to_dict()
+    assert {"terms": {"_type": "article", "boost": 1.1}} == query.Terms(
+        _type="article", boost=1.1
+    ).to_dict()
+    assert {
+        "terms": {"_id": {"index": "my-other-index", "id": "my-id"}, "boost": 1.1}
+    } == query.Terms(
+        _id={"index": "my-other-index", "id": "my-id"}, boost=1.1
+    ).to_dict()
 
 
 def test_bool_to_dict() -> None: