Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the use of dictionaries as values in Terms query #1921

Merged

Conversation

miguelgrinberg
Copy link
Collaborator

Fixes #1920

Verified

This commit was signed with the committer’s verified signature. The key has expired.
AnandChowdhary Anand Chowdhary
Fixes elastic#1920
@miguelgrinberg miguelgrinberg added backport 8.x Backport to 8.x and removed backport 8.x Backport to 8.x labels Oct 4, 2024
@miguelgrinberg miguelgrinberg changed the title Fixed use of dictionaries as values in Terms query Fixed the use of dictionaries as values in Terms query Oct 4, 2024
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@miguelgrinberg miguelgrinberg merged commit fb18f38 into elastic:main Oct 7, 2024
19 checks passed
@miguelgrinberg miguelgrinberg deleted the fix-terms-query-with-dicts branch October 7, 2024 11:27
Copy link

github-actions bot commented Oct 7, 2024

The backport to 8.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.x 8.x
# Navigate to the new working tree
cd .worktrees/backport-8.x
# Create a new branch
git switch --create backport-1921-to-8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 fb18f383adbe5379ecc02b092fe8a5c126a7c8a4
# Push it to GitHub
git push --set-upstream origin backport-1921-to-8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.x

Then, create a pull request where the base branch is 8.x and the compare/head branch is backport-1921-to-8.x.

miguelgrinberg added a commit to miguelgrinberg/elasticsearch-dsl-py that referenced this pull request Oct 7, 2024
@miguelgrinberg miguelgrinberg added backport 8.x Backport to 8.x and removed backport 8.x Backport to 8.x labels Oct 7, 2024
github-actions bot pushed a commit that referenced this pull request Oct 7, 2024
miguelgrinberg added a commit that referenced this pull request Oct 7, 2024
Fixes #1920

(cherry picked from commit fb18f38)

Co-authored-by: Miguel Grinberg <miguel.grinberg@gmail.com>
miguelgrinberg added a commit to miguelgrinberg/elasticsearch-dsl-py that referenced this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terms lookup feature no longer supported due to recent release
3 participants