Try to simplify geometries that fail with TopologyException (#115834) (…

…#115842)

This geometries are valid and they can actually be simplified so lets make the clipping algorithm a best effort and 
return the original geometry in those cases so the simplification can handle it.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

docs/changelog/115834.yaml

@@ -0,0 +1,5 @@
+pr: 115834
+summary: Try to simplify geometries that fail with `TopologyException`
+area: Geo
+type: bug
+issues: []

x-pack/plugin/vector-tile/src/main/java/org/elasticsearch/xpack/vectortile/feature/FeatureFactory.java

@@ -307,8 +307,11 @@ private static org.locationtech.jts.geom.Geometry clipGeometry(
                         return null;
                     }
                 } catch (TopologyException ex) {
-                    // we should never get here but just to be super safe because a TopologyException will kill the node
-                    throw new IllegalArgumentException(ex);
+                    // Note we should never throw a TopologyException as it kill the node
+                    // unfortunately the intersection method is not perfect and it will throw this error for complex
+                    // geometries even when valid. We can still simplify such geometry so we just return the original and
+                    // let the simplification process handle it.
+                    return geometry;
                 }
             }
         }