Try to simplify geometries that fail with TopologyException #115834
Merged
+10
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iverase
added
>bug
:Analytics/Geo
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
the
Team:Analytics
|
Hi @iverase, I've created a changelog YAML for you. |
craigtaverner
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Since we deal with envelope disjoint and contains separately, this seems like a safe enough approach as it should mostly be geometries that are likely intersecting. I guess the worst case scenario is a big geometry that intersects the window with a small corner, and simplifying just that corner would be best, and now we'll simplify the whole geometry. Still better than throwing the exception.
iverase
added
v8.15.3
v8.15.4
auto-backport
This was referenced Oct 29, 2024
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Oct 29, 2024
…115834) This geometries are valid and they can actually be simplified so lets make the clipping algorithm a best effort and return the original geometry in those cases so the simplification can handle it.
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Oct 29, 2024
…115834) This geometries are valid and they can actually be simplified so lets make the clipping algorithm a best effort and return the original geometry in those cases so the simplification can handle it.
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Oct 29, 2024
…115834) This geometries are valid and they can actually be simplified so lets make the clipping algorithm a best effort and return the original geometry in those cases so the simplification can handle it.
iverase
added a commit
that referenced
this pull request
Oct 30, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 30, 2024
…#115842) This geometries are valid and they can actually be simplified so lets make the clipping algorithm a best effort and return the original geometry in those cases so the simplification can handle it. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
iverase
added a commit
that referenced
this pull request
Oct 30, 2024
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Nov 4, 2024
…115834) This geometries are valid and they can actually be simplified so lets make the clipping algorithm a best effort and return the original geometry in those cases so the simplification can handle it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During some testing I noticed that some geometries where failing with a topolygy exception when computing the intersection. This error is not seeing when reading from source because we are swallowing the exceptions but it is visible when doing it from the stored value.
This geometries are valid and they can actually be simplified so lets make the clipping algorithm a best effort and return the original geometry in those cases so the simplification can handle it.
Note: I am working on adding a test but we need to clear the license of the geometry I am using and that might take time.