Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove checkstyle line length suppressions #34884

Closed
33 tasks done
dakrone opened this issue Oct 25, 2018 · 3 comments
Closed
33 tasks done

Remove checkstyle line length suppressions #34884

dakrone opened this issue Oct 25, 2018 · 3 comments
Labels
:Core/Infra/Core Core issues without another label Meta >non-issue >refactoring v6.7.0 v7.0.0-beta1

Comments

@dakrone
Copy link
Member

dakrone commented Oct 25, 2018 •
edited by dliappis
Loading

We've carried these suppressions around for a long time, so this is a meta issue to track removal of the suppressions

They are roughly separated into the following packages (when you assign one, please do the work for both master and 6.x branches):
jakelandis added a commit to jakelandis/elasticsearch that referenced this issue Oct 25, 2018
@jakelandis
Enforce 140 char line lengths for packages action.bulk/delete/explain…
aebec5b 
…/get/index

part of elastic#34884
@jakelandis jakelandis mentioned this issue Oct 25, 2018
Merged
@jdconrad jdconrad mentioned this issue Oct 25, 2018
Merged
dakrone added a commit to dakrone/elasticsearch that referenced this issue Oct 25, 2018
@dakrone
Fix line length for org.elasticsearch.common.* files
1c2755c 
This removes the checkstyle suppressions for things in the `common` package.

Relates to elastic#34884
@dakrone dakrone mentioned this issue Oct 25, 2018
Merged
@not-napoleon not-napoleon mentioned this issue Oct 25, 2018
Merged
@gwbrown gwbrown mentioned this issue Oct 25, 2018
Merged
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this issue Oct 25, 2018
@original-brownbear
Fix LineLength Check Suppressions: index.fielddata
0aad1e4 
* Fix linelength suppressions in index.fielddata
  * Some lines that were too long were dead code => Removed them and all code that became dead because of it
* Relates elastic#34884
@original-brownbear original-brownbear mentioned this issue Oct 25, 2018
Merged
@colings86 colings86 added the :Core/Infra/Core Core issues without another label label Oct 26, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@colings86
Copy link
Contributor

Please remember to add relevant labels to all issues created. At the very least this should include an area label since without and area label issues may fall through the cracks and be missed by teams

original-brownbear added a commit that referenced this issue Oct 26, 2018
@original-brownbear
Fix LineLength Check Suppressions: index.fielddata (#34891)
db12005 
* Fix linelength suppressions in index.fielddata
  * Some lines that were too long were dead code => Removed them and all code that became dead because of it
* Relates #34884
imotov added a commit to imotov/elasticsearch that referenced this issue Oct 26, 2018
@imotov
Fix line length for bootstrap/client/discovery/gateway files
246f021 
Removes the checkstyle suppressions for files in
org.elasticsearch.bootstrap/client/discovery/gateway packages.

Relates to elastic#34884
@imotov imotov mentioned this issue Oct 26, 2018
Merged
dakrone added a commit that referenced this issue Oct 26, 2018
@dakrone
Fix line length for org.elasticsearch.common.* files (#34888)
af28d1f 
This removes the checkstyle suppressions for things in the `common` package.

Relates to #34884
dakrone added a commit that referenced this issue Oct 26, 2018
@dakrone
Fix line length for org.elasticsearch.common.* files (#34888)
20fa20f 
This removes the checkstyle suppressions for things in the `common` package.

Relates to #34884
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this issue Oct 26, 2018
@original-brownbear
Fix LineLength Check Suppressions: index.fielddata (elastic#34891)
688e543 
* Fix linelength suppressions in index.fielddata
  * Some lines that were too long were dead code => Removed them and all code that became dead because of it
* Relates elastic#34884
@original-brownbear original-brownbear mentioned this issue Oct 26, 2018
Merged
@not-napoleon not-napoleon mentioned this issue Oct 26, 2018
Merged
jakelandis added a commit that referenced this issue Oct 26, 2018
@jakelandis
Enforce 140 char line lengths for packages action.bulk/delete/explain…
11fa8d3 
…/get/index (#34885)

part of #34884
imotov added a commit that referenced this issue Oct 26, 2018
@imotov
Fix line length for bootstrap/client/discovery/gateway files (#34905)
01c62fc 
Removes the checkstyle suppressions for files in
org.elasticsearch.bootstrap/client/discovery/gateway packages.

Relates to #34884
imotov added a commit that referenced this issue Oct 26, 2018
@imotov
Fix line length for bootstrap/client/discovery/gateway files (#34905)
f1011e1 
Removes the checkstyle suppressions for files in
org.elasticsearch.bootstrap/client/discovery/gateway packages.

Relates to #34884
rjernst added a commit to rjernst/elasticsearch that referenced this issue Oct 26, 2018
@rjernst
Remove remaining line length violations in o.e.cluster
3fad06f 
relates elastic#34923, elastic#34884
pgomulka added a commit to pgomulka/elasticsearch that referenced this issue Jan 8, 2019
@pgomulka
Fix line length in org.elasticsearch.snapshots (BP elastic#36646)
f2f7958 
Remove the line length suppression for this package and fix offending
lines in both main and test

relates elastic#34884
@pgomulka pgomulka mentioned this issue Jan 8, 2019
Merged
rjernst added a commit that referenced this issue Jan 8, 2019
@rjernst
Remove more checkstyle suppressions (#36735)
86b7193 
This commit removes several more line length violations from checkstyle
suppression.

relates #34884
rjernst added a commit that referenced this issue Jan 8, 2019
@rjernst
Remove more checkstyle suppressions (#36735)
b39a32e 
This commit removes several more line length violations from checkstyle
suppression.

relates #34884
pgomulka added a commit that referenced this issue Jan 9, 2019
@pgomulka
Fix line length in org.elasticsearch.snapshots (BP #36646) (#37234)
0ccd899 
Remove the line length suppression for this package and fix offending
lines in both main and test

relates #34884
@pgomulka pgomulka mentioned this issue Jan 9, 2019
Merged
pgomulka added a commit to pgomulka/elasticsearch that referenced this issue Jan 9, 2019
@pgomulka
Fix line length in org.elasticsearch.routing
fafc1ba 
Remove the line length suppression for this package and fix offending
lines

relates: elastic#34884
pgomulka added a commit that referenced this issue Jan 10, 2019
@pgomulka
Fix line length in org.elasticsearch.routing (#37253)
c812e6a 
Remove the line length suppression for this package and fix offending
lines

relates: #34884
pgomulka added a commit to pgomulka/elasticsearch that referenced this issue Jan 10, 2019
@pgomulka
Fix line length in org.elasticsearch.routing
788a887 
Remove the line length suppression for this package and fix offending
lines
backport elastic#37253

relates: elastic#34884
@pgomulka pgomulka mentioned this issue Jan 10, 2019
Merged
pgomulka added a commit that referenced this issue Jan 11, 2019
@pgomulka
Fix line length in org.elasticsearch.routing (#37309) Bacport#37253
c4bb675 
Remove the line length suppression for this package and fix offending
lines
backport #37253

relates: #34884
ebadyano added a commit that referenced this issue Jan 14, 2019
@ebadyano
Fixing line length for EnvironmentTests and RecoveryTests (#36657)
137a5e9 
Relates #34884
This was referenced Jan 15, 2019
Merged
Merged
Merged
dliappis added a commit that referenced this issue Jan 15, 2019
@dliappis
Fix line length for monitor and remove suppressions (#37456)
19fc59f 
Relates #34884
dliappis added a commit to dliappis/elasticsearch that referenced this issue Jan 15, 2019
@dliappis
Fix line length for node and remove suppresion.
8eae842 
Relates elastic#34884
dliappis added a commit that referenced this issue Jan 15, 2019
@dliappis
Fix line length for monitor and remove suppressions (#37456)
1307fb1 
Relates #34884
dliappis added a commit that referenced this issue Jan 15, 2019
@dliappis
Fix line length for node and remove suppresion (#37454)
6379349 
Relates #34884
dliappis added a commit that referenced this issue Jan 15, 2019
@dliappis
Fix line length for node and remove suppresion (#37454)
0c0e7ca 
Relates #34884
dliappis added a commit that referenced this issue Jan 16, 2019
@dliappis
Fix line length for aliases and remove suppression (#37455)
347cbaf 
Relates #34884
dliappis added a commit that referenced this issue Jan 16, 2019
@dliappis
Fix line length for aliases and remove suppression (#37455)
28e8561 
Relates #34884
@danielmitterdorfer
Copy link
Member

Closing as all related PRs have been merged now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Core/Infra/Core Core issues without another label Meta >non-issue >refactoring v6.7.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dakrone @colings86 @danielmitterdorfer @jasontedor @elasticmachine