Remove line length violations for o.e.cluster (mostly) #34923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes line length violations in most of the classes under org.elasticsearch.cluster.
rjernst
added
>non-issue
:Core/Infra/Core
|
Pinging @elastic/es-core-infra |
|
This PR was getting unwieldy so I capped it around 1k lines changed. I will do the rest of o.e.cluster in a followup. |
nik9000
approved these changes
Oct 26, 2018
| @@ -28,7 +28,8 @@ | |||
| /** | |||
| * A task that can update the cluster state. | |||
| */ | |||
| public abstract class ClusterStateUpdateTask implements ClusterStateTaskConfig, ClusterStateTaskExecutor<ClusterStateUpdateTask>, ClusterStateTaskListener { | |||
| public abstract class ClusterStateUpdateTask | |||
| implements ClusterStateTaskConfig, ClusterStateTaskExecutor<ClusterStateUpdateTask>, ClusterStateTaskListener { | |||
There was a problem hiding this comment.
Could you indent this one extra time?
| @@ -41,7 +42,8 @@ public ClusterStateUpdateTask(Priority priority) { | |||
| } | |||
|
|
|||
| @Override | |||
| public final ClusterTasksResult<ClusterStateUpdateTask> execute(ClusterState currentState, List<ClusterStateUpdateTask> tasks) throws Exception { | |||
| public final ClusterTasksResult<ClusterStateUpdateTask> execute(ClusterState currentState, List<ClusterStateUpdateTask> tasks) | |||
| throws Exception { | |||
There was a problem hiding this comment.
Could you indent this one extra time?
|
This PR is purely mechanical and the CI failure is transient (does not reproduce). I'm going to push this as is. |
rjernst
added a commit
that referenced
this pull request
Oct 26, 2018
This commit removes line length violations in most of the classes under org.elasticsearch.cluster.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Oct 26, 2018
33 tasks
rjernst
added a commit
that referenced
this pull request
Oct 30, 2018
rjernst
added a commit
that referenced
this pull request
Oct 30, 2018
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
This commit removes line length violations in most of the classes under org.elasticsearch.cluster.
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
tomcallahan
added a commit
to tomcallahan/elasticsearch
that referenced
this pull request
Nov 1, 2018
This inserts newlines in order to reduce line lengths in the o.e.action.admin.cluster package to 140 characters or less. This also remves the checkstyle suppressions for affected files. Relates elastic#34884, elastic#34923
tomcallahan
added a commit
that referenced
this pull request
Nov 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes line length violations in most of the classes under
org.elasticsearch.cluster.