Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Dynamically pick up the upper bound snapshot index version #114703

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

arteam
Copy link
Contributor

@arteam arteam commented Oct 14, 2024

Pick an index version between the minimum compatible and latest known version for snapshot testing.

Pick an index version between the minimum compatible and latest known
version for snapshot testing.
@arteam arteam added >test Issues or PRs that are addressing/adding tests :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs labels Oct 14, 2024
@arteam arteam marked this pull request as ready for review October 16, 2024 08:05
@arteam arteam requested review from mark-vieira and DaveCTurner and removed request for mark-vieira October 16, 2024 08:05
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Meta label for distributed team (obsolete) label Oct 16, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

Copy link
Member

@ywangd ywangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arteam arteam merged commit 32dee6a into elastic:main Oct 23, 2024
16 checks passed
smalyshev pushed a commit to smalyshev/elasticsearch that referenced this pull request Oct 23, 2024
…astic#114703)

Pick an index version between the minimum compatible and latest known
version for snapshot testing.
georgewallace pushed a commit to georgewallace/elasticsearch that referenced this pull request Oct 25, 2024
…astic#114703)

Pick an index version between the minimum compatible and latest known
version for snapshot testing.
@DaveCTurner
Copy link
Contributor

Hi @arteam I'm afraid this one isn't so simple, we will continue to support the pre-7.6-version snapshot repository format even in 9.0. Would you revert this change please?

@arteam
Copy link
Contributor Author

arteam commented Oct 30, 2024

I think a bit of an issue here is that the index versions before 8.0 are no longer supported since #112570

jfreden pushed a commit to jfreden/elasticsearch that referenced this pull request Nov 4, 2024
…astic#114703)

Pick an index version between the minimum compatible and latest known
version for snapshot testing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed Meta label for distributed team (obsolete) >test Issues or PRs that are addressing/adding tests v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants