Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Dynamically pick up the upper bound snapshot index version #114703

Merged
merged 3 commits into from
Oct 23, 2024
Merged

[test] Dynamically pick up the upper bound snapshot index version #114703

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
74bb4d4
[test] Dynamically pick up the upper bound snapshot index version
arteam Oct 14, 2024
8af717f
Merge remote-tracking branch 'origin/main' into init-old-snapshot-ver…
arteam Oct 21, 2024
07ac95d
Use IndexVersionUtils.randomVersion
arteam Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions test/framework/src/main/java/org/elasticsearch/snapshots/AbstractSnapshotIntegTestCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@
import org.elasticsearch.common.unit.ByteSizeUnit;
import org.elasticsearch.common.util.concurrent.EsExecutors;
import org.elasticsearch.core.Nullable;
import org.elasticsearch.core.UpdateForV9;
import org.elasticsearch.index.IndexVersion;
import org.elasticsearch.index.IndexVersions;
import org.elasticsearch.index.KnownIndexVersions;
import org.elasticsearch.plugins.Plugin;
import org.elasticsearch.repositories.FinalizeSnapshotContext;
import org.elasticsearch.repositories.RepositoriesService;
Expand Down Expand Up @@ -366,14 +366,16 @@ protected static Settings.Builder indexSettingsNoReplicas(int shards) {
/**
* Randomly write an empty snapshot of an older version to an empty repository to simulate an older repository metadata format.
*/
@UpdateForV9(owner = UpdateForV9.Owner.DISTRIBUTED_COORDINATION)
// This used to pick an index version from 7.0.0 to 8.9.0. The minimum now is 8.0.0 but it's not clear what the upper range should be
protected void maybeInitWithOldSnapshotVersion(String repoName, Path repoPath) throws Exception {
if (randomBoolean() && randomBoolean()) {
initWithSnapshotVersion(
repoName,
repoPath,
IndexVersionUtils.randomVersionBetween(random(), IndexVersions.MINIMUM_COMPATIBLE, IndexVersions.V_8_9_0)
IndexVersionUtils.randomVersionBetween(
random(),
IndexVersions.MINIMUM_COMPATIBLE,
KnownIndexVersions.ALL_VERSIONS.getLast()
)
arteam marked this conversation as resolved.
Show resolved Hide resolved
);
}
}
Expand Down