Revert fast refresh using search shards #115019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As this induces ES-8275 and makes fleet time outs for some APIs. Relates ES-9573
elasticsearchmachine
added
v9.0.0
serverless-linked
kingherc
added
:Distributed Indexing/Engine
kingherc
commented
Oct 17, 2024
| @@ -103,7 +105,10 @@ static boolean shouldLoadRandomAccessFiltersEagerly(IndexSettings settings) { | |||
| boolean loadFiltersEagerlySetting = settings.getValue(INDEX_LOAD_RANDOM_ACCESS_FILTERS_EAGERLY_SETTING); | |||
| boolean isStateless = DiscoveryNode.isStateless(settings.getNodeSettings()); | |||
| if (isStateless) { | |||
| return loadFiltersEagerlySetting && DiscoveryNode.hasRole(settings.getNodeSettings(), DiscoveryNodeRole.SEARCH_ROLE); | |||
| return loadFiltersEagerlySetting | |||
There was a problem hiding this comment.
I was not sure whether to revert this part to its original state, as it was wrong. This has the discussion. Basically the cache should be loaded whenever the shard can be searched. But welcome feedback.
|
Pinging @elastic/es-distributed (Team:Distributed) |
tlrx
approved these changes
Oct 17, 2024
| @@ -126,10 +126,11 @@ protected void asyncShardOperation(GetRequest request, ShardId shardId, ActionLi | |||
| IndexService indexService = indicesService.indexServiceSafe(shardId.getIndex()); | |||
| IndexShard indexShard = indexService.getShard(shardId.id()); | |||
| if (indexShard.routingEntry().isPromotableToPrimary() == false) { | |||
| assert indexShard.indexSettings().isFastRefresh() == false | |||
There was a problem hiding this comment.
I have no idea how serverless upgrade tests are working and we'll see what CI says, but I suppose this can trip if a request is wrongly redirected in a mixed cluster.
There was a problem hiding this comment.
You're right, lets not risk it. I'll comment the assertion and add a TODO.
| @@ -103,7 +105,10 @@ static boolean shouldLoadRandomAccessFiltersEagerly(IndexSettings settings) { | |||
| boolean loadFiltersEagerlySetting = settings.getValue(INDEX_LOAD_RANDOM_ACCESS_FILTERS_EAGERLY_SETTING); | |||
| boolean isStateless = DiscoveryNode.isStateless(settings.getNodeSettings()); | |||
| if (isStateless) { | |||
| return loadFiltersEagerlySetting && DiscoveryNode.hasRole(settings.getNodeSettings(), DiscoveryNodeRole.SEARCH_ROLE); | |||
| return loadFiltersEagerlySetting | |||
lkts
pushed a commit
to lkts/elasticsearch
that referenced
this pull request
Oct 18, 2024
As this induces ES-8275 and makes fleet time outs for some APIs. Relates ES-9573
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Oct 25, 2024
As this induces ES-8275 and makes fleet time outs for some APIs. Relates ES-9573
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Nov 4, 2024
As this induces ES-8275 and makes fleet time outs for some APIs. Relates ES-9573
kingherc
added a commit
to kingherc/elasticsearch
that referenced
this pull request
Nov 12, 2024
The changes of PR elastic#115019 were reverted because it induced ES-8275. Now that the ticket is done, this PR re-introduces the reverted changes. Fast refresh indices should now behave like non fast refresh indices in how they execute (m)gets and searches. I.e., they should use the search shards. For BWC, we define a new transport version. We expect search shards to be upgraded first, before promotable shards. Until the cluster is fully upgraded, the promotable shards (whether upgraded or not) will still receive and execute gets/searches locally. Relates ES-9573
kingherc
added a commit
that referenced
this pull request
Nov 19, 2024
The changes of PR #115019 were reverted because it induced ES-8275. Now that the ticket is done, this PR re-introduces the reverted changes. Fast refresh indices should now behave like non fast refresh indices in how they execute (m)gets and searches. I.e., they should use the search shards. For BWC, we define a new transport version. We expect search shards to be upgraded first, before promotable shards. Until the cluster is fully upgraded, the promotable shards (whether upgraded or not) will still receive and execute gets/searches locally. Relates ES-9573
rjernst
pushed a commit
to rjernst/elasticsearch
that referenced
this pull request
Nov 20, 2024
The changes of PR elastic#115019 were reverted because it induced ES-8275. Now that the ticket is done, this PR re-introduces the reverted changes. Fast refresh indices should now behave like non fast refresh indices in how they execute (m)gets and searches. I.e., they should use the search shards. For BWC, we define a new transport version. We expect search shards to be upgraded first, before promotable shards. Until the cluster is fully upgraded, the promotable shards (whether upgraded or not) will still receive and execute gets/searches locally. Relates ES-9573
alexey-ivanov-es
pushed a commit
to alexey-ivanov-es/elasticsearch
that referenced
this pull request
Nov 28, 2024
The changes of PR elastic#115019 were reverted because it induced ES-8275. Now that the ticket is done, this PR re-introduces the reverted changes. Fast refresh indices should now behave like non fast refresh indices in how they execute (m)gets and searches. I.e., they should use the search shards. For BWC, we define a new transport version. We expect search shards to be upgraded first, before promotable shards. Until the cluster is fully upgraded, the promotable shards (whether upgraded or not) will still receive and execute gets/searches locally. Relates ES-9573
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this induces ES-8275 and makes fleet time outs for some APIs.
Reverts #113478 .
Relates ES-9573