Fix synonyms CI tests timeout #114641
Merged
Fix synonyms CI tests timeout #114641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
needs:triage
carlosdelest
added
:Search Relevance/Analysis
elasticsearchmachine
added
the
needs:risk
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
mayya-sharipova
approved these changes
Oct 11, 2024
kingherc
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
LGTM! If there are still failures, maybe increasing the timeout might help. Or, ignoring the timeout altogether may be helpful:
- do:
cluster.health:
index: .synonyms-2
timeout: 1m
wait_for_status: green
ignore: 408
It will let requests go through then, but it's still annoying that the health might not be green (I'd expect ideally tests to use the synonyms with green health rather than yellow).
benwtrent
reviewed
Oct 15, 2024
| @@ -5,7 +5,7 @@ steps: | |||
| steps: | |||
| - label: "{{matrix.image}} / docker / packaging-tests-unix" | |||
| key: "packaging-tests-unix-docker" | |||
| command: ./.ci/scripts/packaging-test.sh destructiveDistroTest.docker | |||
| command: ./.ci/scripts/packaging-test.sh destructiveDistroTest.docker-cloud-ess | |||
There was a problem hiding this comment.
I screwed up - will get back to this
carlosdelest
force-pushed
the
carlosdelest/fix-synonyms-ci-tests-timeout
branch
2 times, most recently
from
8aa2910 to
d4bd80a
Compare
|
Reopening to test this suggestion |
|
@elasticmachine update branch |
…ts-timeout' into carlosdelest/fix-synonyms-ci-tests-timeout # Conflicts: # rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/synonyms/10_synonyms_put.yml # rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/synonyms/110_synonyms_invalid.yml # rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/synonyms/20_synonyms_get.yml # rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/synonyms/30_synonyms_delete.yml # rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/synonyms/40_synonyms_sets_get.yml # rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/synonyms/50_synonym_rule_put.yml # rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/synonyms/60_synonym_rule_get.yml # rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/synonyms/70_synonym_rule_delete.yml # rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/synonyms/80_synonyms_from_index.yml # rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/synonyms/90_synonyms_reloading_for_synset.yml
carlosdelest
force-pushed
the
carlosdelest/fix-synonyms-ci-tests-timeout
branch
from
5edd935 to
bc07059
Compare
benwtrent
reviewed
Oct 22, 2024
| @@ -58,6 +62,10 @@ setup: | |||
|
|
|||
| - match: { result: "created" } | |||
|
|
|||
| - do: | |||
| cluster.health: | |||
| wait_for_no_initializing_shards: true | |||
There was a problem hiding this comment.
😍
Does this work? Seems likely?
|
Using the changes commented by @kingherc makes this pass. Serverless checks also pass (see PR 3015 in serverless). |
kingherc
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Awesome that it worked! Please note that due to #115019 we had to revert the fast refresh behavioral change, but I think it still makes sense to merge this so that the tests are ready for when we re-incorporate the change in the near future.
Feel free to get a search approval as well before merging.
HUZZAH!
smalyshev
pushed a commit
to smalyshev/elasticsearch
that referenced
this pull request
Oct 23, 2024
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Oct 25, 2024
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #114444
Closes #114443
Closes #114432
(Hopefully) 🤞
Using an alias was making the test flaky. Changed that back to the original version in #114400, and also added this to the rest of the synonyms tests that could be affected by this issue.