Revert "Add ResolvedExpression wrapper (#114592)" #115317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4c15cc0.
original-brownbear
added
>bug
:Data Management/Indices APIs
elasticsearchmachine
added
v9.0.0
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
Hi @original-brownbear, I've created a changelog YAML for you. |
dakrone
approved these changes
Oct 22, 2024
|
Thanks Lee! |
original-brownbear
added
auto-backport
💚 Backport successful
|
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Oct 22, 2024
) This reverts commit 4c15cc0. This commit introduced an orders of magnitude regression when searching many shards.
|
@original-brownbear this needs to go to 8.17 (the 8.x branch) also |
|
Ah right thanks! |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
|
It appears that adding the |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 23, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 23, 2024
|
Thanks again Lee! |
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Oct 25, 2024
) This reverts commit 4c15cc0. This commit introduced an orders of magnitude regression when searching many shards.
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Nov 4, 2024
) This reverts commit 4c15cc0. This commit introduced an orders of magnitude regression when searching many shards.
jbaiera
referenced
this pull request
in jbaiera/elasticsearch
Nov 20, 2024
**Introduction** > In order to make adoption of failure stores simpler for all users, we are introducing a new syntactical feature to index expression resolution: The selector. > > Selectors, denoted with a :: followed by a recognized suffix will allow users to specify which component of an index abstraction they would like to operate on within an API call. In this case, an index abstraction is a concrete index, data stream, or alias; Any abstraction that can be resolved to a set of indices/shards. We define a component of an index abstraction to be some searchable unit of the index abstraction. > > To start, we will support two components: data and failures. Concrete indices are their own data components, while the data component for index aliases are all of the indices contained therein. For data streams, the data component corresponds to their backing indices. Data stream aliases mirror this, treating all backing indices of the data streams they correspond to as their data component. > > The failure component is only supported by data streams and data stream aliases. The failure component of these abstractions refer to the data streams' failure stores. Indices and index aliases do not have a failure component. For more details and examples see elastic#113144. All this work has been cherry picked from there. **Purpose of this PR** This PR is introducing a wrapper around the resolved expression that used to be a `String` to create the base on which the selectors are going to be added. The current PR is just a refactoring and does not and should not change any existing behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 4c15cc0.
This commit introduced an orders of magnitude regression when searching many shards.
Small Rally excerpt: