[ML] Fix for Deberta tokenizer when input sequence exceeds 512 tokens #117595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxhniebergall
added
>bug
:ml
|
Pinging @elastic/ml-core (Team:ML) |
|
Hi @maxhniebergall, I've created a changelog YAML for you. |
…asticsearch into debertaTokenizerTruncationFix
prwhelan
approved these changes
Nov 26, 2024
maxhniebergall
added a commit
to maxhniebergall/elasticsearch
that referenced
this pull request
Nov 26, 2024
…elastic#117595) * Add test and fix * Update docs/changelog/117595.yaml * Remove test which wasn't working
maxhniebergall
added a commit
to maxhniebergall/elasticsearch
that referenced
this pull request
Nov 26, 2024
…elastic#117595) * Add test and fix * Update docs/changelog/117595.yaml * Remove test which wasn't working
cbuescher
pushed a commit
to cbuescher/elasticsearch
that referenced
this pull request
Nov 27, 2024
…elastic#117595) * Add test and fix * Update docs/changelog/117595.yaml * Remove test which wasn't working
alexey-ivanov-es
pushed a commit
to alexey-ivanov-es/elasticsearch
that referenced
this pull request
Nov 28, 2024
…elastic#117595) * Add test and fix * Update docs/changelog/117595.yaml * Remove test which wasn't working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were missing the "balanced" case for the NLP tokenizer which caused exceptions with large inputs. In addition to the fix, I've also added a test which I confirmed fails without the fix, with the same error message as reported.