Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Simplify minimum supported snapshot version handling for Machine Learning jobs #118549

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

valeriy42
Copy link
Contributor

Since in 9.0 we don't need to support snapshots prior to 7.17, we can simplify the changes made in #81039 and re-introduce a single contant to manage the minimum supported snapshot version.

@elasticsearchmachine elasticsearchmachine added v9.0.0 needs:triage Requires assignment of a team area label labels Dec 12, 2024
@valeriy42 valeriy42 added >refactoring :ml Machine learning and removed needs:triage Requires assignment of a team area label labels Dec 12, 2024
@elasticsearchmachine elasticsearchmachine added the Team:ML Meta label for the ML team label Dec 12, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@valeriy42 valeriy42 requested a review from davidkyle December 12, 2024 12:06
@valeriy42 valeriy42 self-assigned this Dec 12, 2024
@valeriy42 valeriy42 changed the title Simplify minimum supported snapshot version handling for Machine Learning jobs [ML] Simplify minimum supported snapshot version handling for Machine Learning jobs Dec 12, 2024
Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@valeriy42 valeriy42 merged commit 23008be into elastic:main Dec 13, 2024
16 checks passed
@valeriy42 valeriy42 deleted the bump-min-snapshot-ver-9 branch December 13, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml Machine learning >refactoring Team:ML Meta label for the ML team v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants