[ML] In 8.x ML will have to tolerate model snapshots for 6.4.0+ #81039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we intended that 8.x ML would only accept model snapshots created in version 7.0.0 or above. However, due to a bug (elastic/ml-cpp#1545) it's not possible to distinguish model snapshots created in versions 6.4.0-7.9.3 inclusive. Therefore, to be sure of meeting the stated policy of accepting model snapshots created in 7.0.0 or above ML will have to really accept those labelled as 6.4.0 or above. Fixes elastic#81011
droberts195
added
>non-issue
:ml
|
Pinging @elastic/ml-core (Team:ML) |
|
Jenkins run elasticsearch-ci/eql-correctness |
|
Jenkins run elasticsearch-ci/rest-compatibility |
|
Jenkins run elasticsearch-ci/part-2 |
|
Jenkins run elasticsearch-ci/bwc |
droberts195
added a commit
to droberts195/elasticsearch
that referenced
this pull request
Nov 25, 2021
…tic#81039) Previously we intended that 8.x ML would only accept model snapshots created in version 7.0.0 or above. However, due to a bug (elastic/ml-cpp#1545) it's not possible to distinguish model snapshots created in versions 6.4.0-7.9.3 inclusive. Therefore, to be sure of meeting the stated policy of accepting model snapshots created in 7.0.0 or above ML will have to really accept those labelled as 6.4.0 or above. Fixes elastic#81011
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 25, 2021
…) (#81048) Previously we intended that 8.x ML would only accept model snapshots created in version 7.0.0 or above. However, due to a bug (elastic/ml-cpp#1545) it's not possible to distinguish model snapshots created in versions 6.4.0-7.9.3 inclusive. Therefore, to be sure of meeting the stated policy of accepting model snapshots created in 7.0.0 or above ML will have to really accept those labelled as 6.4.0 or above. Fixes #81011
droberts195
added a commit
to droberts195/elasticsearch
that referenced
this pull request
Nov 25, 2021
This is a followup to elastic#81039. The same requirement to tolerate model snapshots back to 6.4.0 that applies to the job opening code also applies to the deprecation checker. Again, we tell the user that 7.0.0 is the model snapshot version we support, but we actually have to support versions going back to 6.4.0 because we didn't update the constant in the C++ in 7.0.0. Additionally, the wording of the ML deprecation messages is very slightly updated. The messages are different in the 7.16 branch, where they were updated by elastic#79387. This wording is copied forward to master, but with the tiny change that "Snapshot" is changed to "Model snapshot" in one place. This should make it clearer for users that we're talking about ML model snapshots and not cluster snapshots (which are completely different things). Another reason to change the wording is that the UI is looking for the pattern /[Mm]odel snapshot/ to decide when to display the "Fix" button for upgrading ML model snapshots - see elastic/kibana#119745.
droberts195
added a commit
that referenced
this pull request
Nov 29, 2021
…#81060) This is a followup to #81039. The same requirement to tolerate model snapshots back to 6.4.0 that applies to the job opening code also applies to the deprecation checker. Again, we tell the user that 7.0.0 is the model snapshot version we support, but we actually have to support versions going back to 6.4.0 because we didn't update the constant in the C++ in 7.0.0. Additionally, the wording of the ML deprecation messages is very slightly updated. The messages are different in the 7.16 branch, where they were updated by #79387. This wording is copied forward to master, but with the tiny change that "Snapshot" is changed to "Model snapshot" in one place. This should make it clearer for users that we're talking about ML model snapshots and not cluster snapshots (which are completely different things). Another reason to change the wording is that the UI is looking for the pattern /[Mm]odel snapshot/ to decide when to display the "Fix" button for upgrading ML model snapshots - see elastic/kibana#119745.
droberts195
added a commit
to droberts195/elasticsearch
that referenced
this pull request
Nov 29, 2021
…elastic#81060) This is a followup to elastic#81039. The same requirement to tolerate model snapshots back to 6.4.0 that applies to the job opening code also applies to the deprecation checker. Again, we tell the user that 7.0.0 is the model snapshot version we support, but we actually have to support versions going back to 6.4.0 because we didn't update the constant in the C++ in 7.0.0. Additionally, the wording of the ML deprecation messages is very slightly updated. The messages are different in the 7.16 branch, where they were updated by elastic#79387. This wording is copied forward to master, but with the tiny change that "Snapshot" is changed to "Model snapshot" in one place. This should make it clearer for users that we're talking about ML model snapshots and not cluster snapshots (which are completely different things). Another reason to change the wording is that the UI is looking for the pattern /[Mm]odel snapshot/ to decide when to display the "Fix" button for upgrading ML model snapshots - see elastic/kibana#119745.
droberts195
added a commit
to droberts195/elasticsearch
that referenced
this pull request
Nov 29, 2021
…checker This is a followup to elastic#81039. The same requirement to tolerate model snapshots back to 6.4.0 that applies to the job opening code also applies to the deprecation checker. Again, we tell the user that 7.0.0 is the model snapshot version we support, but we actually have to support versions going back to 6.4.0 because we didn't update the constant in the C++ in 7.0.0. Additionally, the wording of the ML deprecation messages is very slightly updated. The messages are different in the 7.16 branch, where they were updated by elastic#79387. This wording is copied forward to master, but with the tiny change that "Snapshot" is changed to "Model snapshot" in one place. This should make it clearer for users that we're talking about ML model snapshots and not cluster snapshots (which are completely different things). Another reason to change the wording is that the UI is looking for the pattern /[Mm]odel snapshot/ to decide when to display the "Fix" button for upgrading ML model snapshots - see elastic/kibana#119745. Backport of elastic#81060
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 29, 2021
…#81060) (#81101) This is a followup to #81039. The same requirement to tolerate model snapshots back to 6.4.0 that applies to the job opening code also applies to the deprecation checker. Again, we tell the user that 7.0.0 is the model snapshot version we support, but we actually have to support versions going back to 6.4.0 because we didn't update the constant in the C++ in 7.0.0. Additionally, the wording of the ML deprecation messages is very slightly updated. The messages are different in the 7.16 branch, where they were updated by #79387. This wording is copied forward to master, but with the tiny change that "Snapshot" is changed to "Model snapshot" in one place. This should make it clearer for users that we're talking about ML model snapshots and not cluster snapshots (which are completely different things). Another reason to change the wording is that the UI is looking for the pattern /[Mm]odel snapshot/ to decide when to display the "Fix" button for upgrading ML model snapshots - see elastic/kibana#119745.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 29, 2021
…checker (#81105) This is a followup to #81039. The same requirement to tolerate model snapshots back to 6.4.0 that applies to the job opening code also applies to the deprecation checker. Again, we tell the user that 7.0.0 is the model snapshot version we support, but we actually have to support versions going back to 6.4.0 because we didn't update the constant in the C++ in 7.0.0. Additionally, the wording of the ML deprecation messages is very slightly updated. The messages are different in the 7.16 branch, where they were updated by #79387. This wording is copied forward to master, but with the tiny change that "Snapshot" is changed to "Model snapshot" in one place. This should make it clearer for users that we're talking about ML model snapshots and not cluster snapshots (which are completely different things). Another reason to change the wording is that the UI is looking for the pattern /[Mm]odel snapshot/ to decide when to display the "Fix" button for upgrading ML model snapshots - see elastic/kibana#119745. Backport of #81060
This was referenced Dec 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we intended that 8.x ML would only accept model snapshots
created in version 7.0.0 or above. However, due to a bug
(elastic/ml-cpp#1545) it's not possible to distinguish model
snapshots created in versions 6.4.0-7.9.3 inclusive. Therefore,
to be sure of meeting the stated policy of accepting model snapshots
created in 7.0.0 or above ML will have to really accept those
labelled as 6.4.0 or above.
Fixes #81011