Provide explanation of dangling indices, fixes #26008 #26999
Conversation
|
|
||
| === Dangling indices | ||
|
|
||
| When a node joins the cluster, any shards/indices stored in its local `data/` |
There was a problem hiding this comment.
This should refer to shards only.
There was a problem hiding this comment.
I do not see a reason to format "data/" here, we can say "data directory".
Adjusted from PR review comments
|
Thanks, I've adjusted with these suggestions. |
| cluster. This functionality is intended as a best effort to help users who | ||
| lost all master nodes. If a new master node is started which is unaware of | ||
| the other indices in the cluster, adding the old nodes will cause the old | ||
| indices to be imported, instead of being deleted. |
There was a problem hiding this comment.
There's an extra "directory" in the first sentence.
I recommend avoiding future tense unless it's really necessary--and in this case I think it would be clearer to stick to present tense. I'd make the following tweaks:
When a node joins the cluster, any shards stored in its local data directory
that do not exist in the cluster are imported into the cluster. This functionality
is intended as a best effort to help you recover if a cluster loses all master
nodes. If a new master node is started that is unaware of the other indices in
the cluster, the old indices are imported as the old nodes join the cluster, not
deleted.
I reflexively use "that" instead of "which" for dependent clauses--though that "rule" isn't as hard and fast as some folks like to think.
We normally just keep pushing updates to doc PRs until it's ready to merge, then squash to a single commit and merge. Occasionally we'll keep multiple commits when merging, particularly if there are changes that are related, but not reflected in original commit messages.
LGTM as long as the directory stutter is fixed.
|
@jasontedor I think I merged this one too quickly, can you review whenever you get some spare time, no rush on this either. Thanks |
| === Dangling indices | ||
|
|
||
| When a node joins the cluster, any shards stored in its local data directory | ||
| directory which do not already exist in the cluster will be imported into the |
There was a problem hiding this comment.
The word directory is duplicated from the previous line.
* master: Trim down usages of `ShardOperationFailedException` interface (#28312) Do not return all indices if a specific alias is requested via get aliases api. [Test] Lower bwc version for rank-eval rest tests CountedBitSet doesn't need to extend BitSet. (#28239) Calculate sum in Kahan summation algorithm in aggregations (#27807) (#27848) Remove the `update_all_types` option. (#28288) Add information when master node left to DiscoveryNodes' shortSummary() (#28197) Provide explanation of dangling indices, fixes #26008 (#26999)
Adding explanation of dangling indices back to the docs to fix #26008