Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide explanation of dangling indices, fixes #26008 #26999

Merged
merged 2 commits into from
Jan 22, 2018
Merged

Provide explanation of dangling indices, fixes #26008 #26999

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76915f8
Provide explanation of dangling indices, fixes #26965
geekpete Oct 13, 2017
2fe4035
updates to suggested wording and minor typo fix.
geekpete Dec 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions docs/reference/modules/gateway.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,3 +48,12 @@ as long as the following conditions are met:
Recover as long as this many data nodes have joined the cluster.

NOTE: These settings only take effect on a full cluster restart.

=== Dangling indices

When a node joins the cluster, any shards stored in its local data directory
directory which do not already exist in the cluster will be imported into the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word directory is duplicated from the previous line.

cluster. This functionality is intended as a best effort to help users who
lost all master nodes. If a new master node is started which is unaware of
the other indices in the cluster, adding the old nodes will cause the old
indices to be imported, instead of being deleted.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an extra "directory" in the first sentence.

I recommend avoiding future tense unless it's really necessary--and in this case I think it would be clearer to stick to present tense. I'd make the following tweaks:

When a node joins the cluster, any shards stored in its local data directory
that do not exist in the cluster are imported into the cluster. This functionality
is intended as a best effort to help you recover if a cluster loses all master
nodes. If a new master node is started that is unaware of the other indices in
the cluster, the old indices are imported as the old nodes join the cluster, not
deleted.

I reflexively use "that" instead of "which" for dependent clauses--though that "rule" isn't as hard and fast as some folks like to think.

We normally just keep pushing updates to doc PRs until it's ready to merge, then squash to a single commit and merge. Occasionally we'll keep multiple commits when merging, particularly if there are changes that are related, but not reflected in original commit messages.

LGTM as long as the directory stutter is fixed.