[TEST] packaging tests: clean up Vagrantfile #28173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Consolidates provision steps so it's more clear which steps are applied to all boxes * Removes duplicate configuration that was being stomped * Ensure rsync, a dependency for platform steps, is installed on linux * Ruby style changes For elastic#26741
andyb-elastic
added
>non-issue
>test
andyb-elastic
commented
Jan 10, 2018
| PROJECT_DIR = ENV['VAGRANT_PROJECT_DIR'] || Dir.pwd | ||
| config.vm.synced_folder PROJECT_DIR, '/project' | ||
|
|
||
| 'ubuntu-1404'.tap do |box| |
There was a problem hiding this comment.
This way of using tap is a ruby idiom for giving a constant a name within the scope of a block - avoids having to retype it or assign it to a variable that won't be used later
andyb-elastic
commented
Jan 10, 2018
| return 1 | ||
| } | ||
| ensure tar | ||
| ensure curl | ||
| ensure unzip | ||
| ensure rsync |
There was a problem hiding this comment.
rsync is used by the platform tests (which from my understanding we'd like to start using again) and is missing from some of the boxes
andyb-elastic
added a commit
that referenced
this pull request
Feb 2, 2018
* Consolidates provision steps so it's more clear which steps are applied to all boxes * Removes duplicate configuration that was being stomped * Ensure rsync, a dependency for platform steps, is installed on linux * Ruby style changes For #26741
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor is extracted out from #27682
applied to all boxes
For #26741