Allow _update and upsert to read from the transaction log #29264
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,207 @@ | ||
| /* | ||
| * Licensed to Elasticsearch under one or more contributor | ||
| * license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright | ||
| * ownership. Elasticsearch licenses this file to you under | ||
| * the Apache License, Version 2.0 (the "License"); you may | ||
| * not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.elasticsearch.index.engine; | ||
|
|
||
| import org.apache.lucene.index.BinaryDocValues; | ||
| import org.apache.lucene.index.DocValuesType; | ||
| import org.apache.lucene.index.FieldInfo; | ||
| import org.apache.lucene.index.FieldInfos; | ||
| import org.apache.lucene.index.Fields; | ||
| import org.apache.lucene.index.IndexOptions; | ||
| import org.apache.lucene.index.LeafMetaData; | ||
| import org.apache.lucene.index.LeafReader; | ||
| import org.apache.lucene.index.NumericDocValues; | ||
| import org.apache.lucene.index.PointValues; | ||
| import org.apache.lucene.index.SortedDocValues; | ||
| import org.apache.lucene.index.SortedNumericDocValues; | ||
| import org.apache.lucene.index.SortedSetDocValues; | ||
| import org.apache.lucene.index.StoredFieldVisitor; | ||
| import org.apache.lucene.index.Terms; | ||
| import org.apache.lucene.util.Bits; | ||
| import org.apache.lucene.util.BytesRef; | ||
| import org.elasticsearch.index.fielddata.AbstractSortedDocValues; | ||
| import org.elasticsearch.index.fielddata.AbstractSortedSetDocValues; | ||
| import org.elasticsearch.index.mapper.ParentFieldMapper; | ||
| import org.elasticsearch.index.mapper.RoutingFieldMapper; | ||
| import org.elasticsearch.index.mapper.SourceFieldMapper; | ||
| import org.elasticsearch.index.translog.Translog; | ||
|
|
||
| import java.io.IOException; | ||
| import java.nio.charset.StandardCharsets; | ||
| import java.util.Collections; | ||
|
|
||
| /** | ||
| * Internal class that mocks a single doc read from the transaction log as a leaf reader. | ||
| */ | ||
| final class TranslogLeafReader extends LeafReader { | ||
|
|
||
| private final Translog.Index operation; | ||
| private static final FieldInfo FAKE_SOURCE_FIELD | ||
| = new FieldInfo(SourceFieldMapper.NAME, 1, false, false, false, IndexOptions.NONE, DocValuesType.NONE, -1, Collections.emptyMap(), | ||
| 0,0); | ||
| private static final FieldInfo FAKE_ROUTING_FIELD | ||
| = new FieldInfo(RoutingFieldMapper.NAME, 2, false, false, false, IndexOptions.NONE, DocValuesType.NONE, -1, Collections.emptyMap(), | ||
| 0,0); | ||
|
|
||
| TranslogLeafReader(Translog.Index operation) { | ||
| this.operation = operation; | ||
| } | ||
| @Override | ||
| public CacheHelper getCoreCacheHelper() { | ||
| throw new UnsupportedOperationException(); | ||
| } | ||
|
|
||
| @Override | ||
| public Terms terms(String field) { | ||
| throw new UnsupportedOperationException(); | ||
| } | ||
|
|
||
| @Override | ||
| public NumericDocValues getNumericDocValues(String field) { | ||
| throw new UnsupportedOperationException(); | ||
| } | ||
|
|
||
| @Override | ||
| public BinaryDocValues getBinaryDocValues(String field) { | ||
| throw new UnsupportedOperationException(); | ||
| } | ||
|
|
||
| @Override | ||
| public SortedDocValues getSortedDocValues(String field) { | ||
| // TODO this can be removed in 7.0 and upwards we don't support the parent field anymore | ||
| if (field.startsWith(ParentFieldMapper.NAME + "#") && operation.parent() != null) { | ||
| return new AbstractSortedDocValues() { | ||
| @Override | ||
| public int docID() { | ||
| return 0; | ||
| } | ||
|
|
||
| private final BytesRef term = new BytesRef(operation.parent()); | ||
| private int ord; | ||
| @Override | ||
| public boolean advanceExact(int docID) { | ||
| if (docID != 0) { | ||
| throw new IndexOutOfBoundsException("do such doc ID: " + docID); | ||
| } | ||
| ord = 0; | ||
| return true; | ||
| } | ||
|
|
||
| @Override | ||
| public int ordValue() { | ||
| return ord; | ||
| } | ||
|
|
||
| @Override | ||
| public BytesRef lookupOrd(int ord) { | ||
| if (ord == 0) { | ||
| return term; | ||
| } | ||
| return null; | ||
| } | ||
|
|
||
| @Override | ||
| public int getValueCount() { | ||
| return 1; | ||
| } | ||
| }; | ||
| } | ||
| return null; | ||
|
There was a problem hiding this comment. should we throw an exception? |
||
| } | ||
|
|
||
| @Override | ||
| public SortedNumericDocValues getSortedNumericDocValues(String field) { | ||
| throw new UnsupportedOperationException(); | ||
| } | ||
|
|
||
| @Override | ||
| public SortedSetDocValues getSortedSetDocValues(String field) { | ||
| throw new UnsupportedOperationException(); | ||
| } | ||
|
|
||
| @Override | ||
| public NumericDocValues getNormValues(String field) { | ||
| throw new UnsupportedOperationException(); | ||
| } | ||
|
|
||
| @Override | ||
| public FieldInfos getFieldInfos() { | ||
| throw new UnsupportedOperationException(); | ||
| } | ||
|
|
||
| @Override | ||
| public Bits getLiveDocs() { | ||
| throw new UnsupportedOperationException(); | ||
| } | ||
|
|
||
| @Override | ||
| public PointValues getPointValues(String field) { | ||
| throw new UnsupportedOperationException(); | ||
| } | ||
|
|
||
| @Override | ||
| public void checkIntegrity() { | ||
|
|
||
| } | ||
|
|
||
| @Override | ||
| public LeafMetaData getMetaData() { | ||
| throw new UnsupportedOperationException(); | ||
| } | ||
|
|
||
| @Override | ||
| public Fields getTermVectors(int docID) { | ||
| throw new UnsupportedOperationException(); | ||
| } | ||
|
|
||
| @Override | ||
| public int numDocs() { | ||
| return 1; | ||
| } | ||
|
|
||
| @Override | ||
| public int maxDoc() { | ||
| return 1; | ||
| } | ||
|
|
||
| @Override | ||
| public void document(int docID, StoredFieldVisitor visitor) throws IOException { | ||
| if (docID != 0) { | ||
| throw new IllegalArgumentException("no such doc ID " + docID); | ||
| } | ||
| if (visitor.needsField(FAKE_SOURCE_FIELD) == StoredFieldVisitor.Status.YES) { | ||
| assert operation.source().toBytesRef().offset == 0; | ||
| assert operation.source().toBytesRef().length == operation.source().toBytesRef().bytes.length; | ||
| visitor.binaryField(FAKE_SOURCE_FIELD, operation.source().toBytesRef().bytes); | ||
| } | ||
| if (operation.routing() != null && visitor.needsField(FAKE_ROUTING_FIELD) == StoredFieldVisitor.Status.YES) { | ||
| visitor.stringField(FAKE_ROUTING_FIELD, operation.routing().getBytes(StandardCharsets.UTF_8)); | ||
| } | ||
|
There was a problem hiding this comment. I know some visitors won't like that _id is not seen, so maybe assert that |
||
| } | ||
|
|
||
| @Override | ||
| protected void doClose() { | ||
|
|
||
| } | ||
|
|
||
| @Override | ||
| public CacheHelper getReaderCacheHelper() { | ||
| throw new UnsupportedOperationException(); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when do we expect this to be null?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the translog generation is not available anymore I think it’s unlikely but I see a chance. I can add a comment in the code