Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rest tests for get_alias #29513

Merged
merged 2 commits into from
May 22, 2018
Merged

Add rest tests for get_alias #29513

merged 2 commits into from
May 22, 2018

Conversation

olcbean
Copy link
Contributor

@olcbean olcbean commented Apr 13, 2018

Currently if no aliases are provided to get_alias, the response will contain all indices ( even the ones without aliases )
However if all aliases are requested ( by providing _all or * ), then only the indices with aliases are returned ( the ones without aliases are filtered out )

@colings86 colings86 added the :Data Management/Indices APIs APIs to create and manage indices and templates label Apr 13, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@colings86 colings86 added the >test Issues or PRs that are addressing/adding tests label Apr 13, 2018
@mayya-sharipova
Copy link
Contributor

@elasticmachine ok to test

@javanna
Copy link
Member

javanna commented Apr 19, 2018

possibly related to #29538 . I need to catch up and look at both, will do soon-ish.

@olcbean
Copy link
Contributor Author

olcbean commented Apr 23, 2018 •
edited
Loading

This PR is just 'documenting' a strange filtering on the REST layer.
@javanna just reading the msg of #29538, it should not have an effect on this PR ... But it may simplify some of the filtering done on the REST layer.

@javanna
Copy link
Member

javanna commented May 15, 2018

retest this please

javanna
javanna approved these changes May 22, 2018
View reviewed changes
Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @olcbean

@javanna
Copy link
Member

javanna commented May 22, 2018

Relates to #30536 , as it documents some of the strange behaviour of get aliases response.

@javanna javanna merged commit af8ad8d into elastic:master May 22, 2018
javanna pushed a commit that referenced this pull request May 22, 2018
@olcbean @javanna
Add more yaml tests for get alias API (#29513)
ad43231
dnhatn added a commit that referenced this pull request May 22, 2018
@dnhatn
Merge branch 'master' into ccr
fb48b02 
* master:
  QA: Add xpack tests to rolling upgrade (#30795)
  Modify state of VerifyRepositoryResponse for bwc (#30762)
  Reduce CLI scripts to one-liners on Windows (#30772)
  Simplify number of shards setting (#30783)
  Replace Request#setHeaders with addHeader (#30588)
  [TEST] remove endless wait in RestClientTests (#30776)
  [Docs] Fix script-fields snippet execution (#30693)
  Upgrade to Lucene-7.4.0-snapshot-cc2ee23050 (#30778)
  [DOCS] Add SAML configuration information (#30548)
  [DOCS] Remove X-Pack references from SQL CLI (#30694)
  Make http pipelining support mandatory (#30695)
  [Docs] Fix typo in circuit breaker docs (#29659)
  [Feature] Adding a char_group tokenizer (#24186)
  [Docs] Fix broken cross link in documentation
  Test: wait for netty threads in a JUnit ClassRule (#30763)
  Increase the maximum number of filters that may be in the cache. (#30655)
  [Security] Include an empty json object in an json array when FLS filters out all fields (#30709)
  [TEST] Wait for CS to be fully applied in testDeleteCreateInOneBulk
  Add more yaml tests for get alias API (#29513)
  Ignore empty completion input (#30713)
  [DOCS] fixed incorrect default
  [ML] Filter undefined job groups from update calendar actions (#30757)
  Fix docs failure on language analyzers (#30722)
  [Docs] Fix inconsistencies in snapshot/restore doc (#30480)
  Enable installing plugins from snapshots.elastic.co (#30765)
  Remove fedora 26, add 28 (#30683)
  Accept Gradle build scan agreement (#30645)
  Remove logging from elasticsearch-nio jar (#30761)
  Add Delete Repository High Level REST API (#30666)
ywelsch added a commit that referenced this pull request May 23, 2018
@ywelsch
Revert "Add more yaml tests for get alias API (#29513)"
f0a2ccf 
This reverts commit ad43231.
@ywelsch ywelsch mentioned this pull request May 23, 2018
Closed
javanna added a commit to javanna/elasticsearch that referenced this pull request May 23, 2018
@javanna
Restore "Add more yaml tests for get alias API "
262c181 
These additional tests were previously reverted in 6.x due to failing bwc tests.
They should be skipped against 5.6 nodes, bwc tests fail when the node hit by the request is on 5.6.

Relates to elastic#29513
Relates to elastic#25114
Closes elastic#30806
@javanna javanna mentioned this pull request May 23, 2018
Merged
@javanna javanna removed the v6.4.0 label May 23, 2018
dnhatn added a commit that referenced this pull request May 24, 2018
@dnhatn
Merge branch '6.x' into ccr-6.x
2aa0570 
* 6.x:
  [DOCS] Fixes typos in security settings
  Add support for indexed shape routing in geo_shape query (#30760)
  [DOCS] Splits auditing.asciidoc into smaller files
  Painless: Types Section Clean Up (#30283)
  [test] java tests for archive packaging (#30734)
  Deprecate http.pipelining setting (#30786)
  [DOCS] Fix more edit URLs in Stack Overview (#30704)
  Use correct cluster state version for node fault detection (#30810)
  [DOCS] Fixes broken link for native realm
  [DOCS] Clarified audit.index.client.hosts (#30797)
  Change serialization version of doc-value fields.
  Add a `format` option to `docvalue_fields`. (#29639)
  [TEST] Don't expect acks when isolating nodes
  Fixes UpdateSettingsRequestStreamableTests mutate bug
  Revert "Add more yaml tests for get alias API (#29513)"
  Revert "Mutes MachineLearningTests.testNoAttributes_givenSameAndMlEnabled"
  Only allow x-pack metadata if all nodes are ready (#30743)
  Mutes MachineLearningTests.testNoAttributes_givenSameAndMlEnabled
  Use original settings on full-cluster restart (#30780)
  Only ack cluster state updates successfully applied on all nodes (#30672)
  Replace Request#setHeaders with addHeader (#30588)
  [TEST] remove endless wait in RestClientTests (#30776)
  QA: Add xpack tests to rolling upgrade (#30795)
  Add support for search templates to the high-level REST client. (#30473)
  Reduce CLI scripts to one-liners on Windows (#30772)
  Fold RestGetAllSettingsAction in RestGetSettingsAction (#30561)
  Add more yaml tests for get alias API (#29513)
  [Docs] Fix script-fields snippet execution (#30693)
  Convert FieldCapabilitiesResponse to a ToXContentObject. (#30182)
  Remove assert statements from field caps documentation. (#30601)
  Fix a bug in FieldCapabilitiesRequest#equals and hashCode. (#30181)
  Add support for field capabilities to the high-level REST client. (#29664)
  [DOCS] Add SAML configuration information (#30548)
  [DOCS] Remove X-Pack references from SQL CLI (#30694)
  [Docs] Fix typo in circuit breaker docs (#29659)
  [Feature] Adding a char_group tokenizer (#24186)
  Increase the maximum number of filters that may be in the cache. (#30655)
  [Docs] Fix broken cross link in documentation
  Test: wait for netty threads in a JUnit ClassRule (#30763)
  [Security] Include an empty json object in an json array when FLS filters out all fields (#30709)
  [DOCS] fixed incorrect default
  [TEST] Wait for CS to be fully applied in testDeleteCreateInOneBulk
  Enable installing plugins from snapshots.elastic.co (#30765)
  Ignore empty completion input (#30713)
  Fix docs failure on language analyzers (#30722)
  [Docs] Fix inconsistencies in snapshot/restore doc (#30480)
  Add Delete Repository High Level REST API (#30666)
  Reduce CLI scripts to one-liners (#30759)
javanna added a commit that referenced this pull request May 24, 2018
@javanna
Restore "Add more yaml tests for get alias API " (#30814)
6ed1c70 
These additional tests were previously reverted in 6.x due to failing bwc tests.
They should be skipped against 5.6 nodes, bwc tests fail when the node hit by the request is on 5.6.

Relates to #29513
Relates to #25114
Closes #30806
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javanna javanna javanna approved these changes

Assignees
No one assigned
Labels
:Data Management/Indices APIs APIs to create and manage indices and templates >test Issues or PRs that are addressing/adding tests v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@olcbean @elasticmachine @mayya-sharipova @javanna @colings86