Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fedora 26, add 28 #30683

Merged
merged 3 commits into from
May 22, 2018
Merged

Remove fedora 26, add 28 #30683

merged 3 commits into from
May 22, 2018

Conversation

alpar-t
Copy link
Contributor

@alpar-t alpar-t commented May 17, 2018

Closes #30579

Tested with local images, will have to wait for vagrantcloud before merge.
I get the same failure as with fedora 27 locally, assuming that's not related to the image.

ok 236 [UPGRADE] check elasticsearch version is version under test
not ok 237 [UPGRADE] verify that the documents are there after restart
# (in test file /project/build/packaging/bats/tests/80_upgrade.bats, line 111)
#   `curl -s localhost:9200/library/book/1?pretty | grep Elasticsearch' failed
ok 238 [UPGRADE] stop version under test
ok 239 [REINSTALL] install
ok 240 [REINSTALL] purge elasticsearch
ok 241 [REINSTALL] chown directories
ok 242 [REINSTALL] reinstall elasticsearch
ok 243 [REINSTALL] check ownership
REPRODUCE WITH: ./gradlew :qa:vagrant:vagrantFedora27#batsPackagingTest -Dtests.seed=858B8891E728527A

I logged #30682 for tracking the test failure.

@alpar-t alpar-t added >non-issue :Delivery/Build Build or test infrastructure labels May 17, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

jasontedor
jasontedor requested changes May 17, 2018
View reviewed changes
Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to enable the tests look good but I think that also a change is needed in TESTING.asciidoc.

@jasontedor jasontedor added :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts and removed :Delivery/Build Build or test infrastructure labels May 17, 2018
@jasontedor
Copy link
Member

run all packaging tests

@alpar-t
Copy link
Contributor Author

alpar-t commented May 21, 2018

@jasontedor images are up, tests are passing and docs were updated, please take another look.

jasontedor
jasontedor approved these changes May 21, 2018
View reviewed changes
Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@alpar-t alpar-t merged commit 8b7ff69 into elastic:master May 22, 2018
@alpar-t alpar-t deleted the fix/30579 branch May 22, 2018 04:22
dnhatn added a commit that referenced this pull request May 22, 2018
@dnhatn
Merge branch 'master' into ccr
fb48b02 
* master:
  QA: Add xpack tests to rolling upgrade (#30795)
  Modify state of VerifyRepositoryResponse for bwc (#30762)
  Reduce CLI scripts to one-liners on Windows (#30772)
  Simplify number of shards setting (#30783)
  Replace Request#setHeaders with addHeader (#30588)
  [TEST] remove endless wait in RestClientTests (#30776)
  [Docs] Fix script-fields snippet execution (#30693)
  Upgrade to Lucene-7.4.0-snapshot-cc2ee23050 (#30778)
  [DOCS] Add SAML configuration information (#30548)
  [DOCS] Remove X-Pack references from SQL CLI (#30694)
  Make http pipelining support mandatory (#30695)
  [Docs] Fix typo in circuit breaker docs (#29659)
  [Feature] Adding a char_group tokenizer (#24186)
  [Docs] Fix broken cross link in documentation
  Test: wait for netty threads in a JUnit ClassRule (#30763)
  Increase the maximum number of filters that may be in the cache. (#30655)
  [Security] Include an empty json object in an json array when FLS filters out all fields (#30709)
  [TEST] Wait for CS to be fully applied in testDeleteCreateInOneBulk
  Add more yaml tests for get alias API (#29513)
  Ignore empty completion input (#30713)
  [DOCS] fixed incorrect default
  [ML] Filter undefined job groups from update calendar actions (#30757)
  Fix docs failure on language analyzers (#30722)
  [Docs] Fix inconsistencies in snapshot/restore doc (#30480)
  Enable installing plugins from snapshots.elastic.co (#30765)
  Remove fedora 26, add 28 (#30683)
  Accept Gradle build scan agreement (#30645)
  Remove logging from elasticsearch-nio jar (#30761)
  Add Delete Repository High Level REST API (#30666)
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasontedor jasontedor jasontedor approved these changes

Assignees
No one assigned
Labels
:Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts >non-issue Team:Delivery Meta label for Delivery team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop Fedora 26 from and add Fedora 28 to packaging tests
4 participants
@alpar-t @elasticmachine @jasontedor @mark-vieira