_cluster/state should always return cluster_uuid #30143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-core-infra |
bleskes
suggested changes
Apr 25, 2018
|
@bleskes I wonder if I should just make a specific test for the cluster_uuid in that case, then skip only that one for older versions and avoid having none of these REST tests run on older versions? |
|
@pickypg makes sense. |
pickypg
force-pushed
the
feature/always-return-cluster_uuid
branch
from
4d3149f
to
a581a7d
Compare
pickypg
commented
Apr 25, 2018
| --- | ||
| "get cluster state returns cluster_uuid at the top level": | ||
| - skip: | ||
| version: " - 6.99.99" |
There was a problem hiding this comment.
There will be a follow-up PR to change this to 6.3.99 after this PR is merged / backported to 6.x (6.4).
pickypg
force-pushed
the
feature/always-return-cluster_uuid
branch
from
56d7cbc
to
0cd2bb6
Compare
|
jenkins test this |
Currently, the only way to get the REST response for the `/_cluster/state` call to return the `cluster_uuid` is to request the `metadata` metrics, which is one of the most expensive response structures. However, external monitoring agents will likely want the `cluster_uuid` to correlate the response with other API responses whether or not they want cluster metadata.
pickypg
force-pushed
the
feature/always-return-cluster_uuid
branch
from
0cd2bb6
to
fb669f3
Compare
|
jenkins test this |
|
@bleskes Updated with skip logic and CI has calmed down |
bleskes
approved these changes
Apr 30, 2018
pickypg
added a commit
that referenced
this pull request
Apr 30, 2018
Currently, the only way to get the REST response for the `/_cluster/state` call to return the `cluster_uuid` is to request the `metadata` metrics, which is one of the most expensive response structures. However, external monitoring agents will likely want the `cluster_uuid` to correlate the response with other API responses whether or not they want cluster metadata.
|
6.x/6.4: eea10f1 |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
May 1, 2018
* origin/master: [test] add java packaging test project (elastic#30161) Fix macros in changelog (elastic#30269) [DOCS] Fixes syskeygen command name [ML] Include 3rd party C++ component notices (elastic#30132) _cluster/state Skip Test for pre-6.4, not pre-7.0 (elastic#30264) Improve docs for disk watermarks (elastic#30249) [DOCS] Removes redundant Active Directory realm settings (elastic#30190) [DOCS] Removes redundant LDAP realm settings (elastic#30193) _cluster/state should always return cluster_uuid (elastic#30143) HTML5ify Javadoc for core and test framework (elastic#30234) Minor tweaks to reroute documentation (elastic#30246)
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
May 16, 2018
Since elastic#30143, the Cluster State API should always returns the current cluster_uuid in the response body, regardless of the metrics filters. This is not exactly true as it is returned only if metadata metrics and no specific indices are requested. This commit fixes the behavior to always return the cluster_uuid and add new test.
tlrx
added a commit
that referenced
this pull request
May 17, 2018
Since #30143, the Cluster State API should always returns the current cluster_uuid in the response body, regardless of the metrics filters. This is not exactly true as it is returned only if metadata metrics and no specific indices are requested. This commit fixes the behavior to always return the cluster_uuid and add new test.
tlrx
added a commit
that referenced
this pull request
May 17, 2018
Since #30143, the Cluster State API should always returns the current cluster_uuid in the response body, regardless of the metrics filters. This is not exactly true as it is returned only if metadata metrics and no specific indices are requested. This commit fixes the behavior to always return the cluster_uuid and add new test.
ywelsch
pushed a commit
to ywelsch/elasticsearch
that referenced
this pull request
May 23, 2018
Since elastic#30143, the Cluster State API should always returns the current cluster_uuid in the response body, regardless of the metrics filters. This is not exactly true as it is returned only if metadata metrics and no specific indices are requested. This commit fixes the behavior to always return the cluster_uuid and add new test.
89 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the only way to get the REST response for the
/_cluster/statecall to return the
cluster_uuidis to request themetadatametrics,which is one of the most expensive response structures. However, external
monitoring agents will likely want the
cluster_uuidto correlate theresponse with other API responses whether or not they want cluster
metadata.
Relates to elastic/beats#6807