-
Notifications
You must be signed in to change notification settings - Fork 24.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve docs for disk watermarks #30249
Improve docs for disk watermarks #30249
Conversation
* Clarify that the low watermark does not affect brand-new shards. * Replace ES -> Elasticsearch. * Format to 80 columns. Resolves elastic#25163
Pinging @elastic/es-distributed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (one optional suggestion)
85% disk used. It can also be set to an absolute byte value (like `500mb`) | ||
to prevent Elasticsearch from allocating shards if less than the specified | ||
amount of space is available. This setting has no effect on brand-new | ||
shards that have never been allocated before. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make this a little bit more explicit, I would add something along the lines of ", for example when a new index is created".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed it to
This setting has no effect on the primary shards of newly-created indices or, specifically, any shards that have never previously been allocated.
WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
* Clarify that the low watermark does not affect brand-new shards. * Replace ES -> Elasticsearch. * Format to 80 columns. Resolves #25163
* Clarify that the low watermark does not affect brand-new shards. * Replace ES -> Elasticsearch. * Format to 80 columns. Resolves #25163
* Clarify that the low watermark does not affect brand-new shards. * Replace ES -> Elasticsearch. * Format to 80 columns. Resolves #25163
* Clarify that the low watermark does not affect brand-new shards. * Replace ES -> Elasticsearch. * Format to 80 columns. Resolves #25163
* Clarify that the low watermark does not affect brand-new shards. * Replace ES -> Elasticsearch. * Format to 80 columns. Resolves #25163
* origin/master: [test] add java packaging test project (elastic#30161) Fix macros in changelog (elastic#30269) [DOCS] Fixes syskeygen command name [ML] Include 3rd party C++ component notices (elastic#30132) _cluster/state Skip Test for pre-6.4, not pre-7.0 (elastic#30264) Improve docs for disk watermarks (elastic#30249) [DOCS] Removes redundant Active Directory realm settings (elastic#30190) [DOCS] Removes redundant LDAP realm settings (elastic#30193) _cluster/state should always return cluster_uuid (elastic#30143) HTML5ify Javadoc for core and test framework (elastic#30234) Minor tweaks to reroute documentation (elastic#30246)
Resolves #25163