Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch ml basic tests to new style Requests #32483

Merged
merged 2 commits into from
Aug 22, 2018
Merged

Switch ml basic tests to new style Requests #32483

merged 2 commits into from
Aug 22, 2018

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Jul 31, 2018

In #29623 we added Request object flavored requests to the low level
REST client and in #30315 we deprecated the old performRequests. This
changes all calls in the x-pack/qa/ml-basic-multi-node project to use
the new versions.

@nik9000
Switch ml basic tests to new style Requests
fde9f40 
In elastic#29623 we added `Request` object flavored requests to the low level
REST client and in elastic#30315 we deprecated the old `performRequest`s. This
changes all calls in the `x-pack/qa/ml-basic-multi-node` project to use
the new versions.
@nik9000 nik9000 added >non-issue review :Clients/Java Low Level REST Client Minimal dependencies Java Client for Elasticsearch v7.0.0 v6.4.0 labels Jul 31, 2018
@nik9000 nik9000 requested a review from javanna July 31, 2018 01:28
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@nik9000 nik9000 added v6.5.0 and removed v6.4.0 labels Jul 31, 2018
@nik9000
Copy link
Member Author

nik9000 commented Aug 10, 2018

@javanna, could you have a look at this when you get a chance?

javanna
javanna approved these changes Aug 13, 2018
View reviewed changes
Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I wonder if for this type of tests we should not use the high-level REST client, given all the calls to flush, close etc.

@nik9000
Copy link
Member Author

nik9000 commented Aug 21, 2018

I think the high level client would be nice for these tests but I don't really want to make big changes as I do this. I might look into it for the next one though.

@nik9000 nik9000 merged commit 0cc99d2 into elastic:master Aug 22, 2018
nik9000 added a commit that referenced this pull request Aug 22, 2018
@nik9000
Switch ml basic tests to new style Requests (#32483)
8cfea3d 
In #29623 we added `Request` object flavored requests to the low level
REST client and in #30315 we deprecated the old `performRequest`s. This
changes all calls in the `x-pack/qa/ml-basic-multi-node` project to use
the new versions.
nik9000 added a commit that referenced this pull request Aug 22, 2018
@nik9000
Fix backport of switch ml basic tests to new style Requests (#32483)
c2fdfe7
martijnvg added a commit that referenced this pull request Aug 24, 2018
@martijnvg
Merge remote-tracking branch 'es/master' into ccr
82592dd 
* es/master: (62 commits)
  [DOCS] Add docs for Application Privileges (#32635)
  Add versions 5.6.12 and 6.4.1
  Do NOT allow termvectors on nested fields (#32728)
  [Rollup] Return empty response when aggs are missing (#32796)
  [TEST] Add some ACL yaml tests for Rollup (#33035)
  Move non duplicated actions back into xpack core (#32952)
  Test fix - GraphExploreResponseTests should not randomise array elements Closes #33086
  Use `addIfAbsent` instead of checking if an element is contained
  TESTS: Fix Random Fail in MockTcpTransportTests (#33061)
  HLRC: Fix Compile Error From Missing Throws (#33083)
  [DOCS] Remove reload password from docs cf. #32889
  HLRC: Add ML Get Buckets API (#33056)
  Watcher: Improve error messages for CronEvalTool (#32800)
  Search: Support of wildcard on docvalue_fields (#32980)
  Change query field expansion (#33020)
  INGEST: Cleanup Redundant Put Method (#33034)
  SQL: skip uppercasing/lowercasing function tests for AZ locales as well (#32910)
  Fix the default pom file name (#33063)
  Switch ml basic tests to new style Requests (#32483)
  Switch some watcher tests to new style Requests (#33044)
  ...
martijnvg added a commit that referenced this pull request Aug 24, 2018
@martijnvg
Merge remote-tracking branch 'es/6.x' into ccr-6.x
943caaf 
* es/6.x: (58 commits)
  [DOCS] Add docs for Application Privileges (#32635)
  Add versions 5.6.12 and 6.4.1
  [Rollup] Return empty response when aggs are missing (#32796)
  [TEST] Add some ACL yaml tests for Rollup (#33035)
  Test fix - GraphExploreResponseTests should not randomise array elements Closes #33086
  Use `addIfAbsent` instead of checking if an element is contained
  HLRC: Fix Compile Error From Missing Throws (#33083)
  [DOCS] Remove reload password from docs cf. #32889
  Use a dedicated ConnectionManger for RemoteClusterConnection (#32988)
  Watcher: Improve error messages for CronEvalTool (#32800)
  HLRC: Add ML Get Buckets API (#33056)
  Change query field expansion (#33020)
  Search: Support of wildcard on docvalue_fields (#32980)
  Add beta label to MSI on install Elasticsearch page (#28126)
  SQL: skip uppercasing/lowercasing function tests for AZ locales as well (#32910)
  [DOCS] Drafts Elasticsearch 6.4.0 release notes (#33039)
  Fix the default pom file name (#33063)
  Fix backport of switch ml basic tests to new style Requests (#32483)
  Switch ml basic tests to new style Requests (#32483)
  Switch some watcher tests to new style Requests (#33044)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javanna javanna javanna approved these changes

Assignees
No one assigned
Labels
:Clients/Java Low Level REST Client Minimal dependencies Java Client for Elasticsearch >non-issue v6.5.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nik9000 @elasticmachine @javanna @colings86