-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQL: skip uppercasing/lowercasing function tests for AZ locales as well #32910
Conversation
…asing/lowercasing scenarios to the skip list
Pinging @elastic/es-search-aggs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added two minor comments. Otherwise LGTM.
Locale.setDefault(Locale.forLanguageTag("tr")); | ||
StringProcessor proc = new StringProcessor(StringOperation.UCASE); | ||
|
||
// ES-SQL is not Locale sensitive (so far). | ||
// in Turkish locale, small letter "i" is uppercased to "I" with a dot above (unicode 130), otherwise in "i" (unicode 49) | ||
assertEquals("\u0049", proc.process("\u0069")); | ||
|
||
Locale.setDefault(Locale.forLanguageTag("az")); | ||
assertEquals("\u0049", proc.process("\u0069")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might makes sense to restore the original locale after the test so other tests in this class don't run in this local most of the time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same deal here with restoring in a finally
@@ -60,8 +60,9 @@ public SqlSpecTestCase(String fileName, String groupName, String testName, Integ | |||
|
|||
@Override | |||
protected final void doTest() throws Throwable { | |||
boolean goodLocale = !(Locale.getDefault().equals(new Locale.Builder().setLanguageTag("tr").build()) | |||
|| Locale.getDefault().equals(new Locale.Builder().setLanguageTag("tr-TR").build())); | |||
String[] badLocales = new String[] {"tr", "az", "tr-TR", "tr-CY", "az-Latn", "az-Cyrl", "az-Latn-AZ", "az-Cyrl-AZ"}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These locales are not bad :) it's just some application are buggy and cannot work with them correctly. So, maybe we should call them h2IncompatibleLocales
or dottedILocales
or something like this.
@elasticmachine test this please! |
assertEquals("\u0069", proc.process("\u0049")); | ||
|
||
// restore the original Locale | ||
Locale.setDefault(initialLocale); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cna you put the test into a try block and restore in the finally?
Locale.setDefault(Locale.forLanguageTag("tr")); | ||
StringProcessor proc = new StringProcessor(StringOperation.UCASE); | ||
|
||
// ES-SQL is not Locale sensitive (so far). | ||
// in Turkish locale, small letter "i" is uppercased to "I" with a dot above (unicode 130), otherwise in "i" (unicode 49) | ||
assertEquals("\u0049", proc.process("\u0069")); | ||
|
||
Locale.setDefault(Locale.forLanguageTag("az")); | ||
assertEquals("\u0049", proc.process("\u0069")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same deal here with restoring in a finally
…ll (#32910) * Added the rest of the Locales that have different behavior for uppercasing/lowercasing scenarios to the skip list
* es/master: (62 commits) [DOCS] Add docs for Application Privileges (#32635) Add versions 5.6.12 and 6.4.1 Do NOT allow termvectors on nested fields (#32728) [Rollup] Return empty response when aggs are missing (#32796) [TEST] Add some ACL yaml tests for Rollup (#33035) Move non duplicated actions back into xpack core (#32952) Test fix - GraphExploreResponseTests should not randomise array elements Closes #33086 Use `addIfAbsent` instead of checking if an element is contained TESTS: Fix Random Fail in MockTcpTransportTests (#33061) HLRC: Fix Compile Error From Missing Throws (#33083) [DOCS] Remove reload password from docs cf. #32889 HLRC: Add ML Get Buckets API (#33056) Watcher: Improve error messages for CronEvalTool (#32800) Search: Support of wildcard on docvalue_fields (#32980) Change query field expansion (#33020) INGEST: Cleanup Redundant Put Method (#33034) SQL: skip uppercasing/lowercasing function tests for AZ locales as well (#32910) Fix the default pom file name (#33063) Switch ml basic tests to new style Requests (#32483) Switch some watcher tests to new style Requests (#33044) ...
* es/6.x: (58 commits) [DOCS] Add docs for Application Privileges (#32635) Add versions 5.6.12 and 6.4.1 [Rollup] Return empty response when aggs are missing (#32796) [TEST] Add some ACL yaml tests for Rollup (#33035) Test fix - GraphExploreResponseTests should not randomise array elements Closes #33086 Use `addIfAbsent` instead of checking if an element is contained HLRC: Fix Compile Error From Missing Throws (#33083) [DOCS] Remove reload password from docs cf. #32889 Use a dedicated ConnectionManger for RemoteClusterConnection (#32988) Watcher: Improve error messages for CronEvalTool (#32800) HLRC: Add ML Get Buckets API (#33056) Change query field expansion (#33020) Search: Support of wildcard on docvalue_fields (#32980) Add beta label to MSI on install Elasticsearch page (#28126) SQL: skip uppercasing/lowercasing function tests for AZ locales as well (#32910) [DOCS] Drafts Elasticsearch 6.4.0 release notes (#33039) Fix the default pom file name (#33063) Fix backport of switch ml basic tests to new style Requests (#32483) Switch ml basic tests to new style Requests (#32483) Switch some watcher tests to new style Requests (#33044) ...
This is a fix for #32589 (comment).