Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Updates Elasticsearch monitoring tasks #34339

Merged
merged 8 commits into from
Oct 25, 2018

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Oct 5, 2018

Related to elastic/stack-docs#86 and #34369

This PR updates the monitoring configuration tasks in the Elasticsearch Reference to include the usage of Metricbeat.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@lcawl lcawl removed the WIP label Oct 6, 2018
@lcawl lcawl requested a review from ycombinator October 6, 2018 00:23
@lcawl lcawl added the >docs General docs changes label Oct 6, 2018
@lcawl
Copy link
Contributor Author

lcawl commented Oct 10, 2018

On second thought, @ycombinator should the architecture diagram be something more like this (i.e. reflecting the recommendation that Metricbeat exist on each node)?:
es-nodes-metricbeat

@lcawl lcawl added the WIP label Oct 10, 2018
@ycombinator
Copy link
Contributor

ycombinator commented Oct 11, 2018

@lcawl I like where you are going with the new diagram, but unfortunately it has raised more questions than answers for me about how to interpret some of the symbols in these diagrams.

My interpretation/assumptions:

  • The outermost boxes represent Elasticsearch clusters. The one on the left is the Production cluster and the one on the right is the Monitoring cluster.

  • The horizontal rectangular boxes inside the cluster boxes represent Elasticsearch nodes. Since a cluster can contain multiple nodes, I imagine the stacking of the boxes represents multiple nodes. If this assumption is correct, then I wonder what the two stacks were meant to represent in the Production Cluster box, even in the original diagrams before Metricbeat entered this world.

  • Finally, since an Elasticsearch node is a running JVM process, I don't know if it makes sense to show a Metricbeat box inside an Elasticsearch node box. I think it should be shown along side it, as its peer (since Metricbeat will also be a process).


If I may, here is an alternative layout proposal:

  • Keep the outermost cluster boxes as-is.

  • Remove the stacking of the node boxes.

  • Within a cluster box, show 3 un-stacked node boxes, laid out vertically, with ellipses in between the 2nd and 3rd boxes to indicate an arbitrary number of nodes.

  • In the Production cluster diagram, right next to each node box, show a Metricbeat box with a "read metrics" or simply "metrics" arrow going from the node box to the metricbeat box.

WDYT?

@lcawl lcawl removed the WIP label Oct 24, 2018
Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in PR LGTM.

@lcawl
Copy link
Contributor Author

lcawl commented Oct 25, 2018

Verified that gradle checks complete successfully.

@colings86 colings86 added v6.6.0 and removed v6.5.0 labels Oct 25, 2018
@lcawl lcawl merged commit 312df55 into elastic:master Oct 25, 2018
@lcawl lcawl deleted the lcawley-metricbeat branch October 25, 2018 17:32
@lcawl lcawl added the v6.5.1 label Oct 25, 2018
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Oct 26, 2018
* master: (74 commits)
  XContent: Check for bad parsers (elastic#34561)
  Docs: Align prose with snippet (elastic#34839)
  document the search context is freed if the scroll is not extended (elastic#34739)
  Test: Lookup node versions on rest test start (elastic#34657)
  SQL: Return error with ORDER BY on non-grouped. (elastic#34855)
  Reduce channels in AbstractSimpleTransportTestCase (elastic#34863)
  [DOCS] Updates Elasticsearch monitoring tasks (elastic#34339)
  Check self references in metric agg after last doc collection (elastic#33593) (elastic#34001)
  [Docs] Add `indices.query.bool.max_clause_count` setting (elastic#34779)
  Add 6.6.0 version to master (elastic#34847)
  Test: ensure char[] doesn't being with prefix (elastic#34816)
  Remove static import from HLRC doc snippet (elastic#34834)
  Logging: server: clean up logging (elastic#34593)
  Logging: tests: clean up logging (elastic#34606)
  SQL: Fix edge case: `<field> IN (null)` (elastic#34802)
  [Test] Mute FullClusterRestartIT.testShrink() until test is fixed
  SQL: Introduce ODBC mode, similar to JDBC (elastic#34825)
  SQL: handle X-Pack or X-Pack SQL not being available in a more graceful way (elastic#34736)
  [Docs] Add explanation for code snippets line width (elastic#34796)
  CCR: Rename follow-task parameters and stats (elastic#34836)
  ...
@colings86 colings86 added v6.5.0 and removed v6.5.1 labels Nov 2, 2018
@jimczi jimczi added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants