Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging: tests: clean up logging #34606

Merged
merged 2 commits into from
Oct 25, 2018
Merged

Logging: tests: clean up logging #34606

merged 2 commits into from
Oct 25, 2018

Conversation

lipsill
Copy link
Contributor

@lipsill lipsill commented Oct 18, 2018

Replace internal deprecated calls to Loggers.getLogger(Class)
with direct calls to log4j LogManager.getLogger(Class)

Relates to: #32174

Replace internal deprecated calls to `Loggers.getLogger(Class)`
with direct calls to log4j `LogManager.getLogger(Class)`
@andyb-elastic andyb-elastic added the :Core/Infra/Logging Log management and logging utilities label Oct 18, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@andyb-elastic andyb-elastic added the >test Issues or PRs that are addressing/adding tests label Oct 18, 2018
@andyb-elastic
Copy link
Contributor

Thanks for the pull request @lipsill

Jenkins, test this please

@lipsill
Copy link
Contributor Author

lipsill commented Oct 18, 2018

Ops! CI found a checkstyle error [ERROR] /var/lib/jenkins/workspace/elastic+elasticsearch+pull-request/plugins/mapper-murmur3/src/main/java/org/elasticsearch/index/mapper/murmur3/Murmur3FieldMapper.java:84: Line is longer than 140 characters (found 141).
Merging master into the PR: the issue should be fixed by f11a23b.

@andyb-elastic
Copy link
Contributor

Jenkins, ok to test

Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll try and merge this later today.

@nik9000
Copy link
Member

nik9000 commented Oct 19, 2018

Thanks for doing this @lipsill!

@nik9000 nik9000 merged commit 185c06b into elastic:master Oct 25, 2018
nik9000 pushed a commit that referenced this pull request Oct 25, 2018
Replace internal deprecated calls to `Loggers.getLogger(Class)`
with direct calls to log4j `LogManager.getLogger(Class)`
@nik9000
Copy link
Member

nik9000 commented Oct 25, 2018

Backport complete, thanks @lipsill!

jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Oct 26, 2018
* master: (74 commits)
  XContent: Check for bad parsers (elastic#34561)
  Docs: Align prose with snippet (elastic#34839)
  document the search context is freed if the scroll is not extended (elastic#34739)
  Test: Lookup node versions on rest test start (elastic#34657)
  SQL: Return error with ORDER BY on non-grouped. (elastic#34855)
  Reduce channels in AbstractSimpleTransportTestCase (elastic#34863)
  [DOCS] Updates Elasticsearch monitoring tasks (elastic#34339)
  Check self references in metric agg after last doc collection (elastic#33593) (elastic#34001)
  [Docs] Add `indices.query.bool.max_clause_count` setting (elastic#34779)
  Add 6.6.0 version to master (elastic#34847)
  Test: ensure char[] doesn't being with prefix (elastic#34816)
  Remove static import from HLRC doc snippet (elastic#34834)
  Logging: server: clean up logging (elastic#34593)
  Logging: tests: clean up logging (elastic#34606)
  SQL: Fix edge case: `<field> IN (null)` (elastic#34802)
  [Test] Mute FullClusterRestartIT.testShrink() until test is fixed
  SQL: Introduce ODBC mode, similar to JDBC (elastic#34825)
  SQL: handle X-Pack or X-Pack SQL not being available in a more graceful way (elastic#34736)
  [Docs] Add explanation for code snippets line width (elastic#34796)
  CCR: Rename follow-task parameters and stats (elastic#34836)
  ...
kcm pushed a commit that referenced this pull request Oct 30, 2018
Replace internal deprecated calls to `Loggers.getLogger(Class)`
with direct calls to log4j `LogManager.getLogger(Class)`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Logging Log management and logging utilities >test Issues or PRs that are addressing/adding tests v6.6.0 v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants