Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce Logging of Errors in GCS Rest RetriesTests #50761

Merged

Commits on Jan 8, 2020

  1. Enforce Logging of Errors in GCS Rest RetriesTests

    It's impossible to tell why elastic#50754 fails without this change.
    We're failing to close the `exchange` somewhere and there is no
    write timeout in the GCS SDK (something to look into separately)
    only a read timeout on the socket so if we're failing on an assertion without
    reading the full request body (at least into the read-buffer) we're locking up
    waiting forever on `write0`.
    
    This change ensure the `exchange` is closed in the tests where we could lock up
    on a write and logs the failure so we can find out what broke elastic#50754.
    original-brownbear committed Jan 8, 2020
    Configuration menu
    Copy the full SHA
    c3f1445 View commit details
    Browse the repository at this point in the history