Introduce ModelPlotConfig.annotations_enabled setting #57539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
przemekwitek
force-pushed
the
model_annotations_enabled
branch
from
178cc5d
to
36c9cf4
Compare
przemekwitek
changed the title
|
Pinging @elastic/ml-core (:ml) |
benwtrent
reviewed
Jun 3, 2020
...st-high-level/src/test/java/org/elasticsearch/client/ml/job/config/ModelPlotConfigTests.java
Outdated
Show resolved
Hide resolved
...ugin/core/src/test/java/org/elasticsearch/xpack/core/ml/job/config/ModelPlotConfigTests.java
Outdated
Show resolved
Hide resolved
benwtrent
approved these changes
Jun 3, 2020
przemekwitek
added a commit
that referenced
this pull request
Jun 4, 2020
pugnascotia
changed the title
29 tasks
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Aug 4, 2020
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Aug 5, 2020
github-actions bot
pushed a commit
to elastic/elasticsearch-net
that referenced
this pull request
Aug 5, 2020
github-actions bot
pushed a commit
to elastic/elasticsearch-net
that referenced
this pull request
Aug 5, 2020
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Aug 5, 2020
Relates: elastic/elasticsearch#57539 Co-authored-by: Russ Cam <russ.cam@elastic.co>
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Aug 5, 2020
Relates: elastic/elasticsearch#57539 Co-authored-by: Russ Cam <russ.cam@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces user-visible setting (
ModelPlotConfig.annotations_enabled) for enabling/disabling model change annotations.The new setting is placed in
ModelPlotConfigas the model plots and annotations show up together in the UI. However, the user is able to enable/disable model change annotations (ModelPlotConfig.annotations_enabled) independently of enabling/disabling model plot itself (ModelPlotConfig.enabled).Relates #55781