Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Adding annotations_enabled to model plot config #68228

Merged
merged 1 commit into from
Jun 4, 2020
Merged

[ML] Adding annotations_enabled to model plot config #68228

merged 1 commit into from
Jun 4, 2020

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic added review non-issue Indicates to automation that a pull request should not appear in the release notes :ml Feature:Anomaly Detection ML anomaly detection v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jun 4, 2020
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner June 4, 2020 09:45
@jgowdyelastic jgowdyelastic self-assigned this Jun 4, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

walterra
walterra approved these changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

peteharverson
peteharverson approved these changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I have raised #68232 for exposing this setting in the anomaly detection job wizards.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jgowdyelastic jgowdyelastic merged commit c9d1c1f into elastic:master Jun 4, 2020
@jgowdyelastic jgowdyelastic deleted the adding-annotations_enabled-to-model-plot-config branch June 4, 2020 13:59
@jgowdyelastic jgowdyelastic mentioned this pull request Jun 4, 2020
Merged
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Jun 4, 2020
@jgowdyelastic
[ML] Adding annotations_enabled to model plot config (elastic#68228)
ddde11c
jgowdyelastic added a commit that referenced this pull request Jun 4, 2020
@jgowdyelastic
[ML] Adding annotations_enabled to model plot config (#68228) (#68252)
f7c8f7e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@walterra walterra walterra approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels
Feature:Anomaly Detection ML anomaly detection :ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes review v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jgowdyelastic @elasticmachine @kibanamachine @walterra @peteharverson