Skip to content

Commit

Permalink
[EuiButtonGroup] Add title when in iconOnly mode (#5199)
Browse files Browse the repository at this point in the history
* Add title when in iconOnly mode using label

* Update button_group snapshot

* Update CHANGELOG.md

* Move title prop out of textprops

* Update CHANGELOG.md

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
  • Loading branch information
lejara and cchaos committed Sep 21, 2021
1 parent 91baf67 commit b23c9d7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## [`master`](https://github.com/elastic/eui/tree/master)

- Fixed the `title` prop `EuiButtonGroup` to automatically display the `label` provided ([#5199](https://github.com/elastic/eui/pull/5199))
- Updated `barSeriesStyle.displayValue` of the elastic-charts `Theme` for better default styles ([#4845](https://github.com/elastic/eui/pull/4845))
- Added `auto` as value for `defaultHeight` in prop `rowHeightsOptions` in `EuiDataGrid` that allows to content auto-fit to row ([#4958](https://github.com/elastic/eui/pull/4958))
- Updated `titleProps` and `descriptionProps` on `EuiDescriptionList` to extend `CommonProps` ([#5166](https://github.com/elastic/eui/pull/5166))
Expand Down
2 changes: 1 addition & 1 deletion src/components/button/button_group/button_group_button.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,8 @@ export const EuiButtonGroupButton: FunctionComponent<Props> = ({
: 'euiButtonGroupButton__textShift',
ref: buttonTextRef,
'data-text': innerText,
title: innerText,
}}
title={innerText}
{...elementProps}
{...rest}
>
Expand Down

0 comments on commit b23c9d7

Please sign in to comment.