Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiButtonGroup] Add title when in iconOnly mode #5199

Merged
merged 6 commits into from
Sep 21, 2021

Conversation

lejara
Copy link
Contributor

@lejara lejara commented Sep 17, 2021

Summary

Fixes (#5180)

CHANGE

Checklist

  • [ ] Check against all themes for compatibility in both light and dark modes
  • [ ] Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • [ ] Props have proper autodocs and playground toggles
  • [ ] Added documentation
  • [ ] Checked Code Sandbox works for any docs examples
  • [] Added or updated jest tests
  • [ ] Checked for breaking changes and labeled appropriately
  • [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

cla-checker-service bot commented Sep 17, 2021

💚 CLA has been signed

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thanks for the PR @lejara !!

Would you please sign the CLA linked below if you have not done so already. Be sure to use the same email address linked to your Github account.

src/components/button/button_group/button_group_button.tsx Outdated Show resolved Hide resolved
@cchaos
Copy link
Contributor

cchaos commented Sep 17, 2021

Thanks for the update. I'll get our CI (Jenkins) started for you which will run our tests and get a preview built.

Jenkins, test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5199/

@cchaos
Copy link
Contributor

cchaos commented Sep 20, 2021

Flakey test.

Jenkins, test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5199/

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 Simple fixes are my favorite!

I double-checked this locally too by also testing that consumers can override the auto-generated title still and they can.
Screen Shot 2021-09-20 at 12 15 10 PM

It looks like the snapshots won't update because it can' do the innerText calculation so this title prop will never show up in the snapshots.

CHANGELOG.md Outdated Show resolved Hide resolved
lejara and others added 2 commits September 20, 2021 16:18
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
@cee-chen cee-chen enabled auto-merge (squash) September 21, 2021 16:21
@thompsongl
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5199/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants