Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiIcon] Multi-color app icons don't respect custom color strings #4093

Closed
cchaos opened this issue Oct 1, 2020 · 4 comments · Fixed by #4104
Closed

[EuiIcon] Multi-color app icons don't respect custom color strings #4093

cchaos opened this issue Oct 1, 2020 · 4 comments · Fixed by #4104

Comments

@cchaos
Copy link
Contributor

cchaos commented Oct 1, 2020

EuiIcon allows coloring icons via any valid color string or by one of our named color strings that match the branding colors. The app style icons have 2 colors. One that is the inherited fill and the other which uses the class .euiIcon__fillSecondary to fill with a different color.

Our docs specify that passing the color prop will override both the basic fill and the secondary fill.

image

This works properly when the value of color that is passed is one of our named colors like primary or text:
Screen Shot 2020-10-01 at 13 06 30 PM

However, it doesn't properly work when passing a custom color string like a hex value or red:

Screen Shot 2020-10-01 at 13 07 11 PM

@ays14
Copy link

ays14 commented Oct 2, 2020

Hi @cchaos ,

I would like to take it up. Can you assign it to me?
Let me know your response. I'd like to ask a few things about the application.

@cchaos
Copy link
Contributor Author

cchaos commented Oct 2, 2020

Hi @ays14 👋 . We don't actually assign issues to community members, but you are free to work on any issues in our issue list. Usually a simple message of "Hey I'm working on this" will suffice.

@batistaleandro
Copy link

I'm working on this one

@ays14
Copy link

ays14 commented Oct 2, 2020

Thanks for letting me know @cchaos. And @batistaleandro is taking this up, so I think I'll lookout for any other issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants