[EuiIcon] Fix color prop for custom colors #4104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from fill to color
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
Jenkins, test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4104/ |
|
Jenkins, test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4104/ |
added 2 commits
October 13, 2020 14:14
…tom-color-full-mono
|
Jenkins, test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4104/ |
kshitij86
added a commit
to kshitij86/eui
that referenced
this pull request
Nov 29, 2020
* Add fully mono support for EuiIcon custom color, change css property from fill to color
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4093
Add fully mono color support for
EuiIconwhen customcolorprop is provided. Changed CSS property fromfilltocolorbecause under the hood all CSS classes uses variablecurrentColor, so there's no any reason to providefill, because it will be inherited fromcolor. Absolutely the sameprimaryfromnamedColors– they're providecolor.Checklist
[ ] Checked Code Sandbox works for the any docs examples[ ] Checked for breaking changes and labeled appropriately